Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cop_dataspace): adds S1_SAR_GRD_COG and new odata query parameters #1277

Merged
merged 5 commits into from
Jul 26, 2024
Merged

feat(cop_dataspace): adds S1_SAR_GRD_COG and new odata query parameters #1277

merged 5 commits into from
Jul 26, 2024

Conversation

ninsbl
Copy link
Contributor

@ninsbl ninsbl commented Jul 26, 2024 •
edited by sbrunato
Loading

Description

The cop_dataspace provider uses COG-format based GRD data as main _target now. This PR adds the S1_SAR_GRD_COG product type and enhances querying possibilities in cop_dataspace allowing to query based on publicationDate and modificationDate using terms:

  • modifiedAfter
  • modifiedBefore
  • publishedAfter
  • publishedBefore

It also fixes orbitNumber and relativeOrbitNumbe searches, that either were ignored or threw errors.

Further comments

Filtering by publishing or modification date might relevant for other providers too...

@ninsbl
Copy link
Contributor Author

ninsbl commented Jul 26, 2024

Hmm... python /opt/src/eodag/utils/params_mapping_to_csv.py fails when I run tests locally, It seems to write windows line endings and then CSV writer fails with:
UnicodeEncodeError: 'latin-1' codec can't encode character '\u2019' in position 131: ordinal not in range(256)

Any idea how to address that?

@ninsbl
Copy link
Contributor Author

ninsbl commented Jul 26, 2024

The test-failure here: https://github.com/CS-SI/eodag/actions/runs/10109344749/job/27957248216?pr=1277 seems unrelated to the changes...

@sbrunato
Copy link
Collaborator

Hello @ninsbl , and many thanks for this PR!

The test-failure here: https://github.com/CS-SI/eodag/actions/runs/10109344749/job/27957248216?pr=1277 seems unrelated to the changes...

This is because the PR come from a fork and does not have permissions to write tests results in the PR through the dedicated GH-action. No problem, as we can see that they succeeded

@sbrunato
Copy link
Collaborator

Hmm... python /opt/src/eodag/utils/params_mapping_to_csv.py fails when I run tests locally, It seems to write windows line endings and then CSV writer fails with: UnicodeEncodeError: 'latin-1' codec can't encode character '\u2019' in position 131: ordinal not in range(256)

Any idea how to address that?

it is ok, I just added remaining product information generated with tox -e docs and included it in the PR

sbrunato
sbrunato requested changes Jul 26, 2024
View reviewed changes
eodag/resources/product_types.yml Outdated Show resolved Hide resolved
sbrunato
sbrunato approved these changes Jul 26, 2024
View reviewed changes
@sbrunato sbrunato changed the title cop_dataspace: add GRD-COG productType and enhance and fix query options feat(cop_dataspace): adds S1_SAR_GRD_COG and new odata query parameters Jul 26, 2024
@sbrunato sbrunato merged commit 97b7b6f into CS-SI:develop Jul 26, 2024
8 of 9 checks passed
@sbrunato sbrunato added this to the 3.0.0b3.dev milestone Jul 26, 2024
@ninsbl ninsbl mentioned this pull request Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunato sbrunato sbrunato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0b3
Development

Successfully merging this pull request may close these issues.
2 participants
@ninsbl @sbrunato
  NODES
COMMUNITY 2
Idea 2
idea 2
Project 3
USERS 1