-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugins): raise error when http download order fails #1338
Merged
sbrunato
merged 3 commits into
develop
from
1337-raise-error-when-request-to-backend-fails
Oct 11, 2024
Merged
fix(plugins): raise error when http download order fails #1338
sbrunato
merged 3 commits into
develop
from
1337-raise-error-when-request-to-backend-fails
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage (Ubuntu)
Diff against develop
Results for commit: 5d2cb59 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Code Coverage (Windows)
Diff against develop
Results for commit: 5d2cb59 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
amarandon
changed the title
Raise error when request to provider fails
Raise error when request to provider fails #1337
Oct 10, 2024
amarandon
changed the title
Raise error when request to provider fails #1337
Raise error when request to provider fails
Oct 10, 2024
jlahovnik
reviewed
Oct 10, 2024
jlahovnik
approved these changes
Oct 10, 2024
amarandon
commented
Oct 11, 2024
sbrunato
approved these changes
Oct 11, 2024
sbrunato
changed the title
Raise error when request to provider fails
fix(plugins): raise error when http download order fails
Oct 11, 2024
amarandon
added a commit
that referenced
this pull request
Oct 14, 2024
alambare
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1337
When a
HttpDownload.order_download()
fails, the error is logged but this can easily go unnoticed by the user if logs aren't enabled. The purpose of this pull request is to raise an exception instead.However, this exception has a
status_code
attribute set to None, which makes the rest server crash when this status code is compared with integer values:This pull request provides a fix for that by ensuring that the status code defaults to 500.