Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config/productTypes): ignore unindexed fields #996

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

bjgiraudon
Copy link
Collaborator

Description

This PR simply adds an unindexed field to the product types Schema, not used inside of EODAG but relevant for sharing configuration.

Copy link
Contributor

github-actions bot commented Jan 18, 2024

Test Results

    4 files  ±0      4 suites  ±0   4m 16s ⏱️ +2s
  452 tests ±0    449 ✅ ±0   3 💤 ±0  0 ❌ ±0 
1 808 runs  ±0  1 730 ✅ ±0  78 💤 ±0  0 ❌ ±0 

Results for commit 3bf801f. ± Comparison against base commit dda681a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 18, 2024

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 3bf801f

Copy link
Contributor

github-actions bot commented Jan 18, 2024

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 3bf801f

@bjgiraudon bjgiraudon force-pushed the config/productTypes/attributes branch from e9f7076 to 3bf801f Compare January 18, 2024 15:43
@alambare alambare requested a review from sbrunato January 22, 2024 16:35
@bjgiraudon bjgiraudon changed the title refactor(config/productTypes): add unindexed attribute to schema refactor(config/productTypes): ignore unindexed fields Jan 30, 2024
@sbrunato sbrunato merged commit 8bffd13 into develop Jan 30, 2024
12 checks passed
@sbrunato sbrunato deleted the config/productTypes/attributes branch January 30, 2024 08:41
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
  NODES
COMMUNITY 2
Project 3
USERS 1