Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: chore: Remove snapshot repository from parent pom #3864

Merged
merged 2 commits into from
Mar 31, 2021
Merged

review: chore: Remove snapshot repository from parent pom #3864

merged 2 commits into from
Mar 31, 2021

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Mar 26, 2021 •
edited
Loading

#3216

See my latest comments in #3216. I don't see any reason to declare the snapshot repository for anything but distribution management. In Jenkins jobs, we inject the snapshot repository into pom files of other projects.

If we agree to merge this, I'll (after merge) go over all Jenkins jobs and make sure that they correctly pull the latest snapshot (I already know of several that pull from the old snapshot repository).

EDIT: Apparently, spoon-smpl depends on a SNAPSHOT version of spoon-control-flow, so it does need the snapshot repository enabled by default. But that's the concern of spoon-smpl, and not all of the Spoon Maven modules, and so we define it only in spoon-smpl.

@slarse slarse changed the title chore: Remove snapshot repository from parent pom wip: chore: Remove snapshot repository from parent pom Mar 26, 2021
@slarse slarse changed the title wip: chore: Remove snapshot repository from parent pom review: chore: Remove snapshot repository from parent pom Mar 26, 2021
@slarse slarse mentioned this pull request Mar 26, 2021
Merged
@monperrus
Copy link
Collaborator

My understanding is that we do this, we won't push snapshots to OW2 anymore during CD. We need to have it in a profile for everything. WDYT?

@slarse
Copy link
Collaborator Author

slarse commented Mar 29, 2021 •
edited
Loading

My understanding is that we do this, we won't push snapshots to OW2 anymore during CD. We need to have it in a profile for everything. WDYT?

I don't believe this is the case. We have the snapshot repository defined in the distributionManagement section, which should be all that's needed to push snapshots:

spoon/spoon-pom/pom.xml

Lines 92 to 107 in 668a18b

<distributionManagement>
<repository>
<id>ossrh</id>
<url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url>
</repository>
<snapshotRepository>
<id>ow2.org-snapshot</id>
<name>Maven Repository for Spoon Snapshots</name>
<url>https://repository.ow2.org/nexus/content/repositories/snapshots/</url>
</snapshotRepository>
<site>
<id>gforge.inria.fr-site</id>
<name>inria</name>
<url>scp://scm.gforge.inria.fr/home/groups/spoon/htdocs/mvnsites</url>
</site>
</distributionManagement>

From the Maven reference (https://maven.apache.org/pom.html#repository):

Whereas the repositories element specifies in the POM the location and manner in which Maven may download remote artifacts for use by the current project, distributionManagement specifies where (and how) this project will get to a remote repository when it is deployed. The repository elements will be used for snapshot distribution if the snapshotRepository is not defined.

Unless I'm completely misinterpreting the docs, there's no reason to define a repository under the repositories element unless we intend to download artifacts from that repository.

@monperrus
Copy link
Collaborator

Thanks for the additional info. LGTM.

@monperrus monperrus merged commit fc58ee3 into INRIA:master Mar 31, 2021
@monperrus
Copy link
Collaborator

Thanks @slarse

@slarse
Copy link
Collaborator Author

slarse commented Mar 31, 2021

Now I need to vet all of the Jenkins jobs to verify that an up-to-date Spoon snapshot is actually being pulled :)

@slarse slarse deleted the issue/3216-remove-spoon-snapshot-repository branch March 31, 2021 06:48
@monperrus
Copy link
Collaborator

monperrus commented Mar 31, 2021 via email

@slarse
Copy link
Collaborator Author

slarse commented Mar 31, 2021

Oh, and more relevant, it appears as if the snapshot deployment went fine: https://ci.inria.fr/sos/job/Spoon-Snapshot-Deployer/3403/console

@monperrus
Copy link
Collaborator

monperrus commented Mar 31, 2021 via email

@monperrus monperrus mentioned this pull request Aug 19, 2021
Merged
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
@slarse @woutersmeenk
chore: Remove snapshot repository to self (INRIA#3864)
8c2a836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slarse @monperrus
  NODES
COMMUNITY 2
Idea 1
idea 1
Project 6
USERS 1
Verify 1