test: Migrate LogTest to JUnit5 #3939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
|
LGTM, will merge! |
monperrus
changed the title
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3919
The
LogTesthas long been a pet-peeve of mine, because it always fails when I run all tests in IntelliJ IDEA. Running it alone is fine, and running it with Maven is also fine. I think it's something with the JUnit4 parameterized test runner (which never made it past the experimental stage) that doesn't work well with my particular version of IDEA.This PR migrates LogTest to JUnit5 and its much better parameterized test support. And finally I can run all tests and not have this one fail.
Ignore whitespace changes in diff: This PR has a lot of indentation changes. To view the diff without whitespace changes, append
?w=1to the GitHub URL (or click this link: https://github.com/INRIA/spoon/pull/3939/files?w=1)