Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate ProcessingTest to Juit5 #3959

Merged
merged 3 commits into from
May 31, 2021
Merged

test: Migrate ProcessingTest to Juit5 #3959

merged 3 commits into from
May 31, 2021

Conversation

Rohitesh-Kumar-Jain
Copy link
Contributor

#3919

This PR just migrates ProcessingTest to Junit5, pure refactoring.

Also, I have replaced the string message in assertArrayEquals with a supplier (I believe this is part of refactoring right?)

@Rohitesh-Kumar-Jain
Copy link
Contributor Author

One of the major breaking changes for the Assertions is that the order of the parameters changed with the output message parameter moved as the last parameter.

And now as we need to change that order, we can replace the String messages with Supplier.

@slarse
Copy link
Collaborator

slarse commented May 26, 2021

@Rohitesh-Kumar-Jain I don't see a good reason to replace the messages with suppliers. Can you justify that change?

@Rohitesh-Kumar-Jain
Copy link
Contributor Author

@Rohitesh-Kumar-Jain I don't see a good reason to replace the messages with suppliers. Can you justify that change?

I read in a guide that in case we want to enhance our test methods during the migration, we can replace the String messages with Supplier.

Screenshot 2021-05-26 at 2 44 21 PM

Here's the link to the resource, I downloaded it from there only.

@slarse
Copy link
Collaborator

slarse commented May 26, 2021

I have a very hard time seeing the point of that, it just seems like more code for the same result to me. I don't see how it's an enhancement, and the article you linked does not say.

In general, for these migrations, do what you need to do to make it work, and nothing more :)

@Rohitesh-Kumar-Jain
Copy link
Contributor Author

I will replace the supplier with the comment in the next commit

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain changed the title review: test: Migrate ProcessingTest to Juit5 WIP: test: Migrate ProcessingTest to Juit5 May 26, 2021
@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain changed the title WIP: test: Migrate ProcessingTest to Juit5 review: test: Migrate ProcessingTest to Juit5 May 26, 2021
@slarse
Copy link
Collaborator

slarse commented May 28, 2021

@monperrus ping

@monperrus monperrus changed the title review: test: Migrate ProcessingTest to Juit5 test: Migrate ProcessingTest to Juit5 May 31, 2021
@monperrus monperrus merged commit 201c063 into INRIA:master May 31, 2021
@monperrus
Copy link
Collaborator

thanks @Rohitesh-Kumar-Jain

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain deleted the migrate-processingtest-to-junit5 branch June 8, 2021 09:32
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
  NODES
COMMUNITY 2
Project 3
USERS 1