-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Migrate ProcessingTest to Juit5 #3959
test: Migrate ProcessingTest to Juit5 #3959
Conversation
One of the major breaking changes for the Assertions is that the order of the parameters changed with the output message parameter moved as the last parameter. And now as we need to change that order, we can replace the String messages with Supplier. |
@Rohitesh-Kumar-Jain I don't see a good reason to replace the messages with suppliers. Can you justify that change? |
I read in a guide that in case we want to enhance our test methods during the migration, we can replace the String messages with Supplier. Here's the link to the resource, I downloaded it from there only. |
I have a very hard time seeing the point of that, it just seems like more code for the same result to me. I don't see how it's an enhancement, and the article you linked does not say. In general, for these migrations, do what you need to do to make it work, and nothing more :) |
I will replace the supplier with the comment in the next commit |
@monperrus ping |
thanks @Rohitesh-Kumar-Jain |
#3919
This PR just migrates ProcessingTest to Junit5, pure refactoring.
Also, I have replaced the string message in assertArrayEquals with a supplier (I believe this is part of refactoring right?)