refactor(ReferenceBuilder): Extract parameterized type reference creation into helpers #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
slarse
changed the title
slarse
changed the title
slarse
changed the title
monperrus
changed the title
|
have you read "Clean code"? if not, you'll like it @slarse :) |
|
@monperrus I read most of it during my first year in CS (so, that's almost 6 years ago now). It's safe to say it influenced my programming style quite a bit. I've planned to revisit it for quite some time but... time flies. |
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
…tion into helpers (INRIA#3966)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3965
First PR in refactoring
ReferenceBuilder.getTypeReference().This PR extracts the creation of parameterized type references into a set of three smaller helper methods. This will make it easier for me to later handle #3964