refactor(ReferenceBuilder): Extract small reference-building subroutines into helpers #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
|
Thanks @slarse. This refactoring has the good granularity. Hard to review manually but I fully trust the test suite. Will merge. |
monperrus
changed the title
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
…nes into helpers (INRIA#3981)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3965
This PR extracts all of the "sufficiently small subroutines" in
getTypeReferenceinto methods of their own.I can create one PR for each little helper, but as they edit code very close to each other I'd need to do them sequentially (wait for one to get merged before opening the next), so I figured I'd submit like this to begin with.
@monperrus Let me know if you want me to break it up into smaller PRs (perhaps split into 3 PRs with 3 extractions each?), or if this size is OK.