Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add note about using JUnit5 in CONTRIBUTING.md #4125

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Aug 25, 2021

#3919

This PR adds a note in the contributing guidelines that we are migrating to JUnit5, and (among other things) that new test classes must be implemented using JUnit5.

@slarse slarse requested a review from monperrus August 26, 2021 06:16
@monperrus
Copy link
Collaborator

Did some rewording, LGTM.

New test classes must use JUnit5

Would be great to enforce that in CI.

@slarse
Copy link
Collaborator Author

slarse commented Aug 26, 2021

New test classes must use JUnit5

Would be great to enforce that in CI.

In principle that's simple. Do we have any test that performs checks on newly added files (according to Git)? Otherwise I can piece together a script later.

@monperrus
Copy link
Collaborator

Do we have any test that performs checks on newly added files (according to Git)?

Not that I remember in Spoon.

But we have done some work in this direction with https://github.com/STAMP-project/dspot/tree/master/dspot-diff-test-selection (led by @danglotb)

@monperrus monperrus changed the title review: doc: Add note about using JUnit5 in CONTRIBUTING.md doc: Add note about using JUnit5 in CONTRIBUTING.md Aug 26, 2021
@monperrus monperrus merged commit bb129fa into INRIA:master Aug 26, 2021
@slarse
Copy link
Collaborator Author

slarse commented Aug 26, 2021

Do we have any test that performs checks on newly added files (according to Git)?

Not that I remember in Spoon.

But we have done some work in this direction with https://github.com/STAMP-project/dspot/tree/master/dspot-diff-test-selection (led by @danglotb)

That's a li'l bit overkill, all we need is to do is find added .java files and check if any of them contain suspicious references (in particular, org.junit.Test and org.junit.Assert). We can do that sufficiently robustly with just git-diff and grep.

I-Al-Istannen pushed a commit to I-Al-Istannen/spoon that referenced this pull request Aug 29, 2021
Co-authored-by: Martin Monperrus <martin.monperrus@gnieh.org>
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Co-authored-by: Martin Monperrus <martin.monperrus@gnieh.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
  NODES
COMMUNITY 2
Note 11
Project 5
USERS 1