review: refactor(ArraysTest): migrate to junit 5 #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following has changed in the code: Replaced junit 4 test annotation with junit 5 test annotation in testArrayReferences Replaced junit 4 test annotation with junit 5 test annotation in testInitializeWithNewArray Replaced junit 4 test annotation with junit 5 test annotation in testCtNewArrayInnerCtNewArray Replaced junit 4 test annotation with junit 5 test annotation in testCtNewArrayWitComments Replaced junit 4 test annotation with junit 5 test annotation in testParameterizedVarargReference Replaced junit 4 test annotation with junit 5 test annotation in testParameterizedArrayReference Replaced junit 4 test annotation with junit 5 test annotation in testParameterizedArrayVarargReference Replaced junit 4 test annotation with junit 5 test annotation in testParameterizedTypeReference Transformed junit4 assert to junt 5 assertion in testArrayReferences Transformed junit4 assert to junt 5 assertion in testInitializeWithNewArray Transformed junit4 assert to junt 5 assertion in testCtNewArrayInnerCtNewArray Transformed junit4 assert to junt 5 assertion in testCtNewArrayWitComments Transformed junit4 assert to junt 5 assertion in testParameterizedVarargReference Transformed junit4 assert to junt 5 assertion in testParameterizedArrayReference Transformed junit4 assert to junt 5 assertion in testParameterizedArrayVarargReference Transformed junit4 assert to junt 5 assertion in testParameterizedTypeReference
MartinWitt
changed the title
slarse
approved these changes
Jan 5, 2022
|
Don't forget to tag these with #3919 |
|
As I have around 100 more PRs ready, are you fine with sending them in larger batches of 10? |
|
@MartinWitt Did you write a script to change these import statements in each and every test class? It looks tedious otherwise. |
|
https://github.com/MartinWitt/laughing-train I wrote a tool for this. |
@MartinWitt Yes, that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3919
The following has changed in the code:
Replaced junit 4 test annotation with junit 5 test annotation in testArrayReferences
Replaced junit 4 test annotation with junit 5 test annotation in testInitializeWithNewArray
Replaced junit 4 test annotation with junit 5 test annotation in testCtNewArrayInnerCtNewArray
Replaced junit 4 test annotation with junit 5 test annotation in testCtNewArrayWitComments
Replaced junit 4 test annotation with junit 5 test annotation in testParameterizedVarargReference
Replaced junit 4 test annotation with junit 5 test annotation in testParameterizedArrayReference
Replaced junit 4 test annotation with junit 5 test annotation in testParameterizedArrayVarargReference
Replaced junit 4 test annotation with junit 5 test annotation in testParameterizedTypeReference
Transformed junit4 assert to junt 5 assertion in testArrayReferences
Transformed junit4 assert to junt 5 assertion in testInitializeWithNewArray
Transformed junit4 assert to junt 5 assertion in testCtNewArrayInnerCtNewArray
Transformed junit4 assert to junt 5 assertion in testCtNewArrayWitComments
Transformed junit4 assert to junt 5 assertion in testParameterizedVarargReference
Transformed junit4 assert to junt 5 assertion in testParameterizedArrayReference
Transformed junit4 assert to junt 5 assertion in testParameterizedArrayVarargReference
Transformed junit4 assert to junt 5 assertion in testParameterizedTypeReference