Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate InterfaceTest to JUnit 5 #4556

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

Junit4-@before

The JUnit 4 @Before annotation should be replaced with JUnit 5 @BeforeEach annotation.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testDefaultMethodInInterface
  • Replaced junit 4 test annotation with junit 5 test annotation in testDefaultMethodInConsumer
  • Replaced junit 4 test annotation with junit 5 test annotation in testExtendsDefaultMethodInSubInterface
  • Replaced junit 4 test annotation with junit 5 test annotation in testRedefinesDefaultMethodInSubInterface
  • Replaced junit 4 test annotation with junit 5 test annotation in testExtendsStaticMethodInSubInterface
  • Replaced junit 4 test annotation with junit 5 test annotation in testRedefinesStaticMethodInSubInterface
  • Replaced junit 4 test annotation with junit 5 test annotation in testNestedTypesInInterfaceArePublic
  • Replaced junit 4 test annotation with junit 5 test annotation in testNestedTypesInInterfaceAreStatic
  • Replaced junit 4 test annotation with junit 5 test annotation in testImplicitPublicModifierInNestedInterfaceTypeIsRemoved
  • Replaced junit 4 test annotation with junit 5 test annotation in testImplicitStaticModifierInNestedInterfaceTypeIsRemoved

Junit4-@before

  • Replaced @Before annotation with @BeforeEach at method setUp

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testDefaultMethodInInterface
  • Transformed junit4 assert to junit 5 assertion in testDefaultMethodInConsumer
  • Transformed junit4 assert to junit 5 assertion in testExtendsDefaultMethodInSubInterface
  • Transformed junit4 assert to junit 5 assertion in testRedefinesDefaultMethodInSubInterface
  • Transformed junit4 assert to junit 5 assertion in testExtendsStaticMethodInSubInterface
  • Transformed junit4 assert to junit 5 assertion in testRedefinesStaticMethodInSubInterface
  • Transformed junit4 assert to junit 5 assertion in testNestedTypesInInterfaceArePublic
  • Transformed junit4 assert to junit 5 assertion in testNestedTypesInInterfaceAreStatic
  • Transformed junit4 assert to junit 5 assertion in testImplicitPublicModifierInNestedInterfaceTypeIsRemoved
  • Transformed junit4 assert to junit 5 assertion in testImplicitStaticModifierInNestedInterfaceTypeIsRemoved

 The following has changed in the code:
Replaced @before annotation with @beforeeach at method setUp
Replaced junit 4 test annotation with junit 5 test annotation in testDefaultMethodInInterface
Replaced junit 4 test annotation with junit 5 test annotation in testDefaultMethodInConsumer
Replaced junit 4 test annotation with junit 5 test annotation in testExtendsDefaultMethodInSubInterface
Replaced junit 4 test annotation with junit 5 test annotation in testRedefinesDefaultMethodInSubInterface
Replaced junit 4 test annotation with junit 5 test annotation in testExtendsStaticMethodInSubInterface
Replaced junit 4 test annotation with junit 5 test annotation in testRedefinesStaticMethodInSubInterface
Replaced junit 4 test annotation with junit 5 test annotation in testNestedTypesInInterfaceArePublic
Replaced junit 4 test annotation with junit 5 test annotation in testNestedTypesInInterfaceAreStatic
Replaced junit 4 test annotation with junit 5 test annotation in testImplicitPublicModifierInNestedInterfaceTypeIsRemoved
Replaced junit 4 test annotation with junit 5 test annotation in testImplicitStaticModifierInNestedInterfaceTypeIsRemoved
Transformed junit4 assert to junit 5 assertion in testDefaultMethodInInterface
Transformed junit4 assert to junit 5 assertion in testDefaultMethodInConsumer
Transformed junit4 assert to junit 5 assertion in testExtendsDefaultMethodInSubInterface
Transformed junit4 assert to junit 5 assertion in testRedefinesDefaultMethodInSubInterface
Transformed junit4 assert to junit 5 assertion in testExtendsStaticMethodInSubInterface
Transformed junit4 assert to junit 5 assertion in testRedefinesStaticMethodInSubInterface
Transformed junit4 assert to junit 5 assertion in testNestedTypesInInterfaceArePublic
Transformed junit4 assert to junit 5 assertion in testNestedTypesInInterfaceAreStatic
Transformed junit4 assert to junit 5 assertion in testImplicitPublicModifierInNestedInterfaceTypeIsRemoved
Transformed junit4 assert to junit 5 assertion in testImplicitStaticModifierInNestedInterfaceTypeIsRemoved
@monperrus monperrus merged commit 3c1eace into INRIA:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
  NODES
COMMUNITY 2
Project 3
USERS 1