Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate LambdaTest to JUnit 5 #4565

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

Junit4-@before

The JUnit 4 @Before annotation should be replaced with JUnit 5 @BeforeEach annotation.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithExpressionBodyAndWithoutParameter
  • Replaced junit 4 test annotation with junit 5 test annotation in testTypeAccessInLambdaNoClassPath
  • Replaced junit 4 test annotation with junit 5 test annotation in testFieldAccessInLambdaNoClassPath
  • Replaced junit 4 test annotation with junit 5 test annotation in testFieldAccessInLambdaNoClassPathExternal1Example
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithExpressionBodyAndWithoutTypeForParameter
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithExpressionBodyAndWithMultiParameters
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithExpressionBodyAndWithParameterTyped
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithExpressionBodyAndWithMultiParametersTyped
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithStatementBodyAndWithoutParameters
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithStatementBodyAndWithParameter
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionInIfConditional
  • Replaced junit 4 test annotation with junit 5 test annotation in testCompileLambdaGeneratedBySpoon
  • Replaced junit 4 test annotation with junit 5 test annotation in testTypeParameterOfLambdaWithoutType
  • Replaced junit 4 test annotation with junit 5 test annotation in testTypeParameterOfLambdaWithoutType2
  • Replaced junit 4 test annotation with junit 5 test annotation in testTypeParameterWithImplicitArrayType
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaWithPrimitiveParameter
  • Replaced junit 4 test annotation with junit 5 test annotation in testBuildExecutableReferenceFromLambda
  • Replaced junit 4 test annotation with junit 5 test annotation in testEqualsLambdaParameterRef
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaMethod
  • Replaced junit 4 test annotation with junit 5 test annotation in testGetOverriddenMethodWithFunction
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaFilter
  • Replaced junit 4 test annotation with junit 5 test annotation in testInterfaceWithObjectMethods
  • Replaced junit 4 test annotation with junit 5 test annotation in testLambdaWithGenericExtendingMultipleInterfaces
  • Replaced junit 4 test annotation with junit 5 test annotation in testCastLambdaWithIntersection
  • Replaced junit 4 test annotation with junit 5 test annotation in testGetDeclarationOnTypeParameterFromLambda
  • Replaced junit 4 test annotation with junit 5 test annotation in test_addParameterAt_addsParameterToSpecifiedPosition
  • Replaced junit 4 test annotation with junit 5 test annotation in test_addParameterAt_throwsOutOfBoundsException_whenPositionIsOutOfBounds
  • Replaced junit 4 test annotation with junit 5 test annotation in singleParameterLambdaWithoutParentheses

Junit4-@before

  • Replaced @Before annotation with @BeforeEach at method setUp

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testTypeAccessInLambdaNoClassPath
  • Transformed junit4 assert to junit 5 assertion in testFieldAccessInLambdaNoClassPath
  • Transformed junit4 assert to junit 5 assertion in testFieldAccessInLambdaNoClassPathExternal1Example
  • Transformed junit4 assert to junit 5 assertion in testLambdaExpressionInIfConditional
  • Transformed junit4 assert to junit 5 assertion in testTypeParameterOfLambdaWithoutType
  • Transformed junit4 assert to junit 5 assertion in testTypeParameterOfLambdaWithoutType2
  • Transformed junit4 assert to junit 5 assertion in testTypeParameterWithImplicitArrayType
  • Transformed junit4 assert to junit 5 assertion in testLambdaWithPrimitiveParameter
  • Transformed junit4 assert to junit 5 assertion in testBuildExecutableReferenceFromLambda
  • Transformed junit4 assert to junit 5 assertion in testEqualsLambdaParameterRef
  • Transformed junit4 assert to junit 5 assertion in testLambdaMethod
  • Transformed junit4 assert to junit 5 assertion in testGetOverriddenMethodWithFunction
  • Transformed junit4 assert to junit 5 assertion in testInterfaceWithObjectMethods
  • Transformed junit4 assert to junit 5 assertion in testLambdaWithGenericExtendingMultipleInterfaces
  • Transformed junit4 assert to junit 5 assertion in assertHasStrings
  • Transformed junit4 assert to junit 5 assertion in assertTypedBy
  • Transformed junit4 assert to junit 5 assertion in assertParametersSizeIs
  • Transformed junit4 assert to junit 5 assertion in assertParameterTypedBy
  • Transformed junit4 assert to junit 5 assertion in assertHasExpressionBody
  • Transformed junit4 assert to junit 5 assertion in assertStatementBody
  • Transformed junit4 assert to junit 5 assertion in assertParameterIsNamedBy
  • Transformed junit4 assert to junit 5 assertion in assertIsWellPrinted
  • Transformed junit4 assert to junit 5 assertion in testGetDeclarationOnTypeParameterFromLambda
  • Transformed junit4 assert to junit 5 assertion in test_addParameterAt_throwsOutOfBoundsException_whenPositionIsOutOfBounds

 The following has changed in the code:
Replaced @before annotation with @beforeeach at method setUp
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithExpressionBodyAndWithoutParameter
Replaced junit 4 test annotation with junit 5 test annotation in testTypeAccessInLambdaNoClassPath
Replaced junit 4 test annotation with junit 5 test annotation in testFieldAccessInLambdaNoClassPath
Replaced junit 4 test annotation with junit 5 test annotation in testFieldAccessInLambdaNoClassPathExternal1Example
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithExpressionBodyAndWithoutTypeForParameter
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithExpressionBodyAndWithMultiParameters
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithExpressionBodyAndWithParameterTyped
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithExpressionBodyAndWithMultiParametersTyped
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithStatementBodyAndWithoutParameters
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionWithStatementBodyAndWithParameter
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaExpressionInIfConditional
Replaced junit 4 test annotation with junit 5 test annotation in testCompileLambdaGeneratedBySpoon
Replaced junit 4 test annotation with junit 5 test annotation in testTypeParameterOfLambdaWithoutType
Replaced junit 4 test annotation with junit 5 test annotation in testTypeParameterOfLambdaWithoutType2
Replaced junit 4 test annotation with junit 5 test annotation in testTypeParameterWithImplicitArrayType
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaWithPrimitiveParameter
Replaced junit 4 test annotation with junit 5 test annotation in testBuildExecutableReferenceFromLambda
Replaced junit 4 test annotation with junit 5 test annotation in testEqualsLambdaParameterRef
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaMethod
Replaced junit 4 test annotation with junit 5 test annotation in testGetOverriddenMethodWithFunction
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaFilter
Replaced junit 4 test annotation with junit 5 test annotation in testInterfaceWithObjectMethods
Replaced junit 4 test annotation with junit 5 test annotation in testLambdaWithGenericExtendingMultipleInterfaces
Replaced junit 4 test annotation with junit 5 test annotation in testCastLambdaWithIntersection
Replaced junit 4 test annotation with junit 5 test annotation in testGetDeclarationOnTypeParameterFromLambda
Replaced junit 4 test annotation with junit 5 test annotation in test_addParameterAt_addsParameterToSpecifiedPosition
Replaced junit 4 test annotation with junit 5 test annotation in test_addParameterAt_throwsOutOfBoundsException_whenPositionIsOutOfBounds
Replaced junit 4 test annotation with junit 5 test annotation in singleParameterLambdaWithoutParentheses
Transformed junit4 assert to junit 5 assertion in testTypeAccessInLambdaNoClassPath
Transformed junit4 assert to junit 5 assertion in testFieldAccessInLambdaNoClassPath
Transformed junit4 assert to junit 5 assertion in testFieldAccessInLambdaNoClassPathExternal1Example
Transformed junit4 assert to junit 5 assertion in testLambdaExpressionInIfConditional
Transformed junit4 assert to junit 5 assertion in testTypeParameterOfLambdaWithoutType
Transformed junit4 assert to junit 5 assertion in testTypeParameterOfLambdaWithoutType2
Transformed junit4 assert to junit 5 assertion in testTypeParameterWithImplicitArrayType
Transformed junit4 assert to junit 5 assertion in testLambdaWithPrimitiveParameter
Transformed junit4 assert to junit 5 assertion in testBuildExecutableReferenceFromLambda
Transformed junit4 assert to junit 5 assertion in testEqualsLambdaParameterRef
Transformed junit4 assert to junit 5 assertion in testLambdaMethod
Transformed junit4 assert to junit 5 assertion in testGetOverriddenMethodWithFunction
Transformed junit4 assert to junit 5 assertion in testInterfaceWithObjectMethods
Transformed junit4 assert to junit 5 assertion in testLambdaWithGenericExtendingMultipleInterfaces
Transformed junit4 assert to junit 5 assertion in assertHasStrings
Transformed junit4 assert to junit 5 assertion in assertTypedBy
Transformed junit4 assert to junit 5 assertion in assertParametersSizeIs
Transformed junit4 assert to junit 5 assertion in assertParameterTypedBy
Transformed junit4 assert to junit 5 assertion in assertHasExpressionBody
Transformed junit4 assert to junit 5 assertion in assertStatementBody
Transformed junit4 assert to junit 5 assertion in assertParameterIsNamedBy
Transformed junit4 assert to junit 5 assertion in assertIsWellPrinted
Transformed junit4 assert to junit 5 assertion in testGetDeclarationOnTypeParameterFromLambda
Transformed junit4 assert to junit 5 assertion in test_addParameterAt_throwsOutOfBoundsException_whenPositionIsOutOfBounds
@monperrus monperrus merged commit 8b62115 into INRIA:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
  NODES
COMMUNITY 2
Project 3
USERS 1