[controller] Add node selectors for csi components #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duckhawk
reviewed
Dec 25, 2024
AleksZimin
changed the title
astef
approved these changes
Dec 26, 2024
AleksZimin
force-pushed
the
add-node-selectors
branch
from
3f0cc45 to
1b23f58
Compare
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
force-pushed
the
add-node-selectors
branch
3 times, most recently
from
a166493 to
aa38b1a
Compare
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
force-pushed
the
add-node-selectors
branch
4 times, most recently
from
7094221 to
951d9ad
Compare
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
force-pushed
the
add-node-selectors
branch
from
951d9ad to
4751e7c
Compare
AleksZimin
force-pushed
the
add-node-selectors
branch
from
f03e5e6 to
56691c6
Compare
This reverts commit 56691c6. Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
force-pushed
the
add-node-selectors
branch
from
f7f7c39 to
395f6c4
Compare
astef
requested changes
Jan 10, 2025
images/controller/src/pkg/controller/node_selector_reconciler.go
Outdated
Show resolved
Hide resolved
images/controller/src/pkg/controller/node_selector_reconciler.go
Outdated
Show resolved
Hide resolved
Merged
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a
nodeSelectorsetting in ModuleConfig that allows users to specify which nodes can run thecsi-nfscomponents. Only on these selected nodes will be able to mount NFS shares into pods as volumes. The implementation includes safeguards to ensure that the removal of components does not disrupt active workloads.Why do we need it, and what problem does it solve?
The addition of
nodeSelectorprovides finer control over wherecsi-nfscomponents are deployed, ensuring NFS shares are only accessible on specific nodes. This setup improves operational control and resource utilization.Without safeguard, changes to the
nodeSelectorcould unintentionally disrupt workloads by prematurely removingcsi-nfscomponents. The implemented checks prevent this by:csi-nfscomponents from it.csi-controlleris present on an excluded node, novolumesnapshotorPVCwith the provisionernfs.csi.k8s.iois in aPendingstate.What is the expected result?
csi-nfscomponents are deployed only on nodes matching thenodeSelectorcriteria.csi-nfscomponents from nodes happens only when:csi-controller, there are noPendingvolumesnapshotorPVCresources for the provisionernfs.csi.k8s.io.Checklist