Use std::addressof to instead of plain '&'.

Otherwise the code won't compile if the '&' operater is overloaded and return something that cannot be casted to void *.
google · May 12, 2019 · 2fc2383 · 2fc2383
1 parent 5299815
commit 2fc2383
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/googletest/include/gtest/gtest-printers.h b/googletest/include/gtest/gtest-printers.h
@@ -152,8 +152,8 @@ class TypeWithoutFormatter {
   // This default version is called when kTypeKind is kOtherType.
   static void PrintValue(const T& value, ::std::ostream* os) {
     PrintBytesInObjectTo(static_cast<const unsigned char*>(
-                             reinterpret_cast<const void*>(&value)),
-                         sizeof(value), os);
+                             reinterpret_cast<const void*>(
+                                 std::addressof(value))), sizeof(value), os);
   }
 };