Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated model_doc/barthez.md to Korean #33980

Merged
merged 4 commits into from
Oct 28, 2024
Merged

🌐 [i18n-KO] Translated model_doc/barthez.md to Korean #33980

merged 4 commits into from
Oct 28, 2024

Conversation

Jwaminju
Copy link
Contributor

@Jwaminju Jwaminju commented Oct 5, 2024

What does this PR do?

Translated the model_doc/barthez.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@junejae, @Jwaminju, @010kim, @4N3MONE, @boyunJang

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

@Jwaminju Jwaminju changed the title [i18n-KO] Translated model_doc/barthez.md to Korean 🌐 [i18n-KO] Translated model_doc/barthez.md to Korean Oct 5, 2024
@Jwaminju Jwaminju changed the title 🌐 [i18n-KO] Translated model_doc/barthez.md to Korean 🌐 [i18n-KO] Translated model_doc/barthez.md to Korean Oct 5, 2024
stevhliu
stevhliu approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Feel free to change this PR from a draft whenever you're ready!

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Jwaminju Jwaminju marked this pull request as ready for review October 19, 2024 04:58
@Jwaminju Jwaminju force-pushed the barthez.md branch from dd5d32a to 7c3caa6 Compare October 19, 2024 06:21
@Jwaminju Jwaminju force-pushed the barthez.md branch from 7c3caa6 to 47c7ee0 Compare October 19, 2024 06:22
@Jwaminju
Copy link
Contributor Author

Jwaminju commented Oct 19, 2024 •
edited
Loading

Hello, I'm looking into how to esolve the setup_and_quality failure. Thanks in advance!

Some diff and their modeling code did not match.

@stevhliu
Copy link
Member

Hey, it looks like the setup_and_quality test is passing now. The build_pr_documentation issue has been resolved on main, so if you wouldn't mind, can you rebase your branch on it to get the fix? 🤗

@Jwaminju
Copy link
Contributor Author

Hi, @stevhliu!
Thanks you so much for your review :) I have rebased the branch!
Best Regards,
Minju

@stevhliu stevhliu merged commit 1f7539c into huggingface:main Oct 28, 2024
9 checks passed
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
@Jwaminju @stevhliu @BernardZach
🌐 [i18n-KO] Translated model_doc/barthez.md to Korean (huggingface#…
16c3476 
…33980)

* docs: ko: model_doc/barthez.md

* feat: nmt draft

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
@Jwaminju @stevhliu @BernardZach
🌐 [i18n-KO] Translated model_doc/barthez.md to Korean (huggingface#…
4208f6d 
…33980)

* docs: ko: model_doc/barthez.md

* feat: nmt draft

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jwaminju @HuggingFaceDocBuilderDev @stevhliu
  NODES
COMMUNITY 2
innovation 1
Project 5
USERS 3