Avoid many test failures for LlavaNextVideoForConditionalGeneration
#34070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
changed the title
LlavaNextVideoForConditionalGeneration
ydshieh
commented
Oct 11, 2024
Comment on lines
+1233
to
+1234
| if any(model_name == model_class.__name__ for model_name in ["LlavaNextVideoForConditionalGeneration"]): | ||
| self.skipTest(f"DoLa is failing for {model_class.__name__}") |
There was a problem hiding this comment.
@gante told me it's ok to skip
ArthurZucker
approved these changes
Oct 11, 2024
NielsRogge
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Oct 21, 2024
…huggingface#34070) * skip * [run-slow] llava_next_video * skip * [run-slow] video_llava, llava_next_video * skip * [run-slow] llava_next_video --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…huggingface#34070) * skip * [run-slow] llava_next_video * skip * [run-slow] video_llava, llava_next_video * skip * [run-slow] llava_next_video --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
…huggingface#34070) * skip * [run-slow] llava_next_video * skip * [run-slow] video_llava, llava_next_video * skip * [run-slow] llava_next_video --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This test
test_dola_decoding_samplefailed forLlavaNextVideoand affect many subsequential tests for that model