-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trainer hyperparameter search kwargs docs update #34459
Trainer hyperparameter search kwargs docs update #34459
Conversation
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Thanks for your patience and for trying out all these potential fixes! Unfortunately, it looks like it didn't work :( I'm not sure why the other CI tests aren't running for you. @ydshieh do you happen to know why the other tests aren't running? |
@LysandreJik @ArthurZucker, not sure why the two tests just hang without ever starting. This happened in #34311 as well, and opening a new PR didn't help. Do you think its ok to just merge this? |
Trying to push this branch on another to see if it triggers it |
I pushed the branch to another and it now works. Unfortunately couldn't get to the root of the issue as the last commit was too old; @stevhliu, let me know if you see this issue happening again. In the meantime, yes, let's merge it as soon as it's green. |
* doc: Trainer.hyperparameter_search docstring discrepancy solved * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
* doc: Trainer.hyperparameter_search docstring discrepancy solved * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
What does this PR do?
superseding of #34311
Fixes #34239