Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trainer hyperparameter search kwargs docs update #34459

Conversation

GuillemGSubies
Copy link
Contributor

@GuillemGSubies GuillemGSubies commented Oct 28, 2024

What does this PR do?

superseding of #34311

Fixes #34239

@GuillemGSubies
Copy link
Contributor Author

@stevhliu

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu
Copy link
Member

Thanks for your patience and for trying out all these potential fixes! Unfortunately, it looks like it didn't work :( I'm not sure why the other CI tests aren't running for you. @ydshieh do you happen to know why the other tests aren't running?

@stevhliu
Copy link
Member

@LysandreJik @ArthurZucker, not sure why the two tests just hang without ever starting. This happened in #34311 as well, and opening a new PR didn't help. Do you think its ok to just merge this?

@LysandreJik
Copy link
Member

Trying to push this branch on another to see if it triggers it

@LysandreJik
Copy link
Member

I pushed the branch to another and it now works. Unfortunately couldn't get to the root of the issue as the last commit was too old; @stevhliu, let me know if you see this issue happening again. In the meantime, yes, let's merge it as soon as it's green.

@LysandreJik LysandreJik merged commit d8a5d31 into huggingface:main Nov 19, 2024
10 checks passed
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* doc: Trainer.hyperparameter_search docstring discrepancy solved

* Apply suggestions from code review

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
* doc: Trainer.hyperparameter_search docstring discrepancy solved

* Apply suggestions from code review

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer.hyperparameter_search kwargs parameter has an inexact definition if using Optuna
4 participants
  NODES
COMMUNITY 2
innovation 1
Project 5
USERS 6