fix TrainerState doc because num_input_tokens_seen is unused by defau… #34593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @stevhliu! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
2015aroras
pushed a commit
to 2015aroras/transformers
that referenced
this pull request
Nov 15, 2024
huggingface#34593) fix TrainerState doc because num_input_tokens_seen is unused by default config Co-authored-by: kangsheng <kangsheng@meituan.com>
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
huggingface#34593) fix TrainerState doc because num_input_tokens_seen is unused by default config Co-authored-by: kangsheng <kangsheng@meituan.com>
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
huggingface#34593) fix TrainerState doc because num_input_tokens_seen is unused by default config Co-authored-by: kangsheng <kangsheng@meituan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #34567.
"
include_num_input_tokens_seenargument is set toFalseby default, similar toload_best_model_at_end. However, the documentation forbest_metricandbest_model_checkpointstrongly implies that these two arguments will have no effect when the corresponding flag is not set. This PR makes the documentation consistent."Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.