Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[peft] Given that self.active_adapter is deprecated, avoid using it #34804

Merged

Conversation

tomaarsen
Copy link
Member

What does this PR do?

PeftAdapterMixin.active_adapter has been deprecated since #26407 added multi-adapter support, but it's still being used in PeftAdapterMixin.get_adapter_state_dict. This results in a FutureWarning every time I save a checkpoint after training with model.add_adapter(...).

This PR updates the latter to use the correct PeftAdapterMixin.active_adapters()[0] method instead, which is identical in behaviour, except minus the warning.

The deprecated active_adapter:

def active_adapter(self) -> str:
warnings.warn(
"The `active_adapter` method is deprecated and will be removed in a future version.", FutureWarning
)
return self.active_adapters()[0]

Additionally, the comment

The model will use `self.active_adapter()`

in enable_adapters seemed to be a bit misleading - that method wasn't being used. For clarity, I removed it.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker @BenjaminBossan

  • Tom Aarsen

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, LGTM.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ArthurZucker ArthurZucker merged commit 11cc229 into huggingface:main Nov 25, 2024
22 of 24 checks passed
@tomaarsen tomaarsen deleted the fix/peft_deprecation_active_adapter branch November 25, 2024 15:06
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…it (huggingface#34804)

* Given that self.active_adapter is deprecated, avoid using it

* Remove misleading comment - `self.active_adapter` is not used (and deprecated)
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
…it (huggingface#34804)

* Given that self.active_adapter is deprecated, avoid using it

* Remove misleading comment - `self.active_adapter` is not used (and deprecated)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
  NODES
COMMUNITY 2
innovation 1
Project 5
USERS 1