[peft
] Given that self.active_adapter
is deprecated, avoid using it
#34804
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PeftAdapterMixin.active_adapter
has been deprecated since #26407 added multi-adapter support, but it's still being used inPeftAdapterMixin.get_adapter_state_dict
. This results in a FutureWarning every time I save a checkpoint after training withmodel.add_adapter(...)
.This PR updates the latter to use the correct
PeftAdapterMixin.active_adapters()[0]
method instead, which is identical in behaviour, except minus the warning.The deprecated
active_adapter
:transformers/src/transformers/integrations/peft.py
Lines 433 to 438 in 54739a3
Additionally, the comment
in
enable_adapters
seemed to be a bit misleading - that method wasn't being used. For clarity, I removed it.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @BenjaminBossan