Skipping aqlm non working inference tests till fix merged #34865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
reviewed
Nov 22, 2024
src/transformers/testing_utils.py
Outdated
Comment on lines
349
to
359
| def skip_if_aqlm_inference_not_fixed(test_case): | ||
| """ | ||
| Decorator marking tests for inference using aqlm models. | ||
|
|
||
| These tests will be skipped till the issue from aqlm side is resolved | ||
| """ | ||
| return unittest.skip( | ||
| reason="inference doesn't work with quantized aqlm models using torch.Any type with recent torch versions" | ||
| )(test_case) | ||
|
|
||
|
|
There was a problem hiding this comment.
don't need to create a seperate function for this as this is something that we will remove. You can just use the decorator like this @skip("reason_for_skipping")
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the inference part of AQLM they use the type
torch.Anywhich was deprecated in torch 2.5. This PR simply skips inference tests with AQLM models till the fix Vahe1994/AQLM#139 is merged to fix the CI.Who can review ?
@SunMarc