Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLIP: this is correct now #35081

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Follows the prev PR #34876, as the prev one was appending image tokens after BOS. It should be the other way around. Sorry, the last commit to increase readability messed up concatenation order

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought why are we adding this after, but was in a rush!

@ArthurZucker ArthurZucker merged commit e682c17 into huggingface:main Dec 5, 2024
17 checks passed
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
  NODES
COMMUNITY 2
innovation 1
Project 5
USERS 1