Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): clarify experimental network features #15228

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

chore(docs): clarify experimental network features #15228

wants to merge 9 commits into from
+11 −7

Conversation

mmomjian
Copy link
Contributor

To be discussed: do we want to keep associated issues open, or is it more reasonable to close them with a link to this FAQ?

#15225

#14945

#14845

#14741

#7124

@mmomjian mmomjian added documentation Improvements or additions to documentation changelog:documentation labels Jan 10, 2025
@alextran1502
Copy link
Contributor

We should probably modified the text here with the (Experimental) text as well
image

It is in en-US.json file with the key client_cert_title

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

📖 Documentation deployed to pr-15228.preview.immich.app

alextran1502
alextran1502 approved these changes Jan 10, 2025
View reviewed changes
@mmomjian
Copy link
Contributor Author

Alex what is your opinion on the linked issues? should we close them with a link to the docs, should we make a meta issue, or leave as is?

@alextran1502
Copy link
Contributor

Alex what is your opinion on the linked issues? should we close them with a link to the docs, should we make a meta issue, or leave as is?

I think we should make a META issue

@mmomjian
Copy link
Contributor Author

Alex what is your opinion on the linked issues? should we close them with a link to the docs, should we make a meta issue, or leave as is?

I think we should make a META issue

I think that makes sense, I can take care of it

@bo0tzz
Copy link
Member

bo0tzz commented Jan 10, 2025

Let's link the meta issue in the FAQ entry. Thank you!

@mmomjian mmomjian mentioned this pull request Jan 10, 2025
Open
bo0tzz
bo0tzz approved these changes Jan 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

@bo0tzz bo0tzz bo0tzz approved these changes

Assignees
No one assigned
Labels
changelog:documentation documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmomjian @alextran1502 @bo0tzz
  NODES
COMMUNITY 2
Project 5
USERS 1