fix(api): vim.fn.writefile() to accept lua strings as input #30763 #31930
+33
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this. Test coverage should probably go in |
justinmk
reviewed
Jan 9, 2025
| /// | ||
| /// @return true on success, or false on failure. | ||
|
|
||
| static bool write_string(FileDescriptor *const fp, const char *const data) |
There was a problem hiding this comment.
nearly identical to write_blob. can we parameterize write_blob instead of copy-pasting it
https://github.com/neovim/neovim/blob/master/CONTRIBUTING.md links to https://github.com/neovim/neovim/blob/master/test/README.md#running-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30763
This is my first time contributing to this project, so how do i add test case coverage to the pr ?