-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add comment to string_buffer.h
#27640
base: main
Are you sure you want to change the base?
Conversation
I'm sorry, but I think this is far too many changes to be reviewable. Please send individual PRs for individual issues and definitely don't send in 1000 line diffs in C++ files. |
Thank you for your feedback! I appreciate your concern about the size of the changes. I was worried that breaking it down into too many PRs might become overwhelming. I will split the issues into smaller, individual PRs. |
but don't do all the individual PRs at once! please go slowly |
string_buffer.h
and some enhancementstring_buffer.h
and some enhancement
string_buffer.h
and some enhancementstring_buffer.h
I know, I know. Now I'm reviewing the c-code, and refine it one by one. I'll only commit new PRs of a c-file if the PRs of last c-file are all resolved, in order to avoid that there are too many PRs blocking. I'm just worried about if I commit several PRs of one c-file in the same time it might become overwhelming. |
I will mark this PR as |
Add comments to
string_buffer.h
.