Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add comment to string_buffer.h #27640

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

fengluoqiuwu
Copy link
Contributor

@fengluoqiuwu fengluoqiuwu commented Oct 25, 2024

Add comments to string_buffer.h.

@ngoldbaum
Copy link
Member

I'm sorry, but I think this is far too many changes to be reviewable. Please send individual PRs for individual issues and definitely don't send in 1000 line diffs in C++ files.

@fengluoqiuwu fengluoqiuwu marked this pull request as draft October 26, 2024 02:23
@fengluoqiuwu
Copy link
Contributor Author

I'm sorry, but I think this is far too many changes to be reviewable. Please send individual PRs for individual issues and definitely don't send in 1000 line diffs in C++ files.

Thank you for your feedback! I appreciate your concern about the size of the changes. I was worried that breaking it down into too many PRs might become overwhelming. I will split the issues into smaller, individual PRs.

@ngoldbaum
Copy link
Member

but don't do all the individual PRs at once! please go slowly

@fengluoqiuwu fengluoqiuwu marked this pull request as ready for review October 26, 2024 06:30
@fengluoqiuwu fengluoqiuwu marked this pull request as draft October 26, 2024 06:30
@fengluoqiuwu fengluoqiuwu changed the title EHC: Add comment in string_buffer.h and some enhancement DOC: Add comment in string_buffer.h and some enhancement Oct 26, 2024
@fengluoqiuwu fengluoqiuwu changed the title DOC: Add comment in string_buffer.h and some enhancement DOC: Add comment to string_buffer.h Oct 26, 2024
@fengluoqiuwu
Copy link
Contributor Author

but don't do all the individual PRs at once! please go slowly

I know, I know. Now I'm reviewing the c-code, and refine it one by one. I'll only commit new PRs of a c-file if the PRs of last c-file are all resolved, in order to avoid that there are too many PRs blocking. I'm just worried about if I commit several PRs of one c-file in the same time it might become overwhelming.

@fengluoqiuwu
Copy link
Contributor Author

I will mark this PR as Ready for Review after addressing the other PRs related to string_buffer.h, as the comments are based on the new names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
  NODES
COMMUNITY 2
INTERN 1
Project 5
USERS 1