Skip to content

Commit

Permalink
chore: remove dead test (#2137)
Browse files Browse the repository at this point in the history
This pull request includes updates to the Go version specification in
the GitHub Actions workflows and the removal of a test suite for the
`instrumentationdevice` controller.

Changes to GitHub Actions workflows:

*
[`.github/workflows/build.yaml`](diffhunk://#diff-d0777657fa3fd81d23aaf7273e58aee453b04e67882517900c56daeef9b3e4c1L46-R46):
Updated the `go-version` specification from double quotes to single
quotes in multiple job steps.
[[1]](diffhunk://#diff-d0777657fa3fd81d23aaf7273e58aee453b04e67882517900c56daeef9b3e4c1L46-R46)
[[2]](diffhunk://#diff-d0777657fa3fd81d23aaf7273e58aee453b04e67882517900c56daeef9b3e4c1L121-R121)
[[3]](diffhunk://#diff-d0777657fa3fd81d23aaf7273e58aee453b04e67882517900c56daeef9b3e4c1L134-R134)
[[4]](diffhunk://#diff-d0777657fa3fd81d23aaf7273e58aee453b04e67882517900c56daeef9b3e4c1L146-R146)
[[5]](diffhunk://#diff-d0777657fa3fd81d23aaf7273e58aee453b04e67882517900c56daeef9b3e4c1L158-R158)

Removal of test suite:

*
[`instrumentor/controllers/instrumentationdevice/suite_test.go`](diffhunk://#diff-ba43311eab39abad82636769e90ee6086c1b750ee814ee92f9e66e5a7b2bc03dL1-L131):
Removed the entire test suite for the `instrumentationdevice`
controller, including setup and teardown logic.
  • Loading branch information
BenElferink authored Jan 6, 2025
1 parent 4bbc40a commit 18a3fc2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 138 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
uses: docker/setup-buildx-action@v3
- uses: actions/setup-go@v5
with:
go-version: "1.23.0"
go-version: '1.23.0'
- name: Build Instrumentor Image
uses: docker/build-push-action@v6
with:
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
run: |
make test
build-and-test-odiglet:
runs-on: ubuntu-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Docker Buildx
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: "1.23.0"
go-version: '1.23.0'
- name: Set up Goreleaser
uses: goreleaser/goreleaser-action@v5
with:
Expand All @@ -131,7 +131,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.23.0"
go-version: '1.23.0'
- name: Test k8sutils module
working-directory: ./k8sutils
run: |
Expand All @@ -143,7 +143,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.23.0"
go-version: '1.23.0'
- name: Test common module
working-directory: ./common
run: |
Expand All @@ -155,8 +155,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.23.0"
go-version: '1.23.0'
- name: Test procdiscovery module
working-directory: ./procdiscovery
run: |
go test -v ./...
go test -v ./...
131 changes: 0 additions & 131 deletions instrumentor/controllers/instrumentationdevice/suite_test.go

This file was deleted.

0 comments on commit 18a3fc2

Please sign in to comment.
  NODES
COMMUNITY 1
Note 1
Project 3
USERS 1