[GEN-2177]: add awaitToast function for improved notification handling in Cypress tests #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at improving the Cypress tests and adding new constants for better identification and notifications. The most important changes include updates to the Cypress test files to add toast notifications, modifications to constants for better data identification, and adjustments to the test descriptions to include source and destination counts.
Updates to Cypress tests:
frontend/webapp/cypress/e2e/02-onboarding.cy.ts: Modified the test to check for the existence of 5 sources within the "default" namespace.frontend/webapp/cypress/e2e/03-sources.cy.ts: AddedawaitToastfunction calls to wait for toast notifications and modified the test to check for the existence of sources within the namespace. [1] [2] [3] [4]frontend/webapp/cypress/e2e/04-destinations.cy.ts: AddedawaitToastfunction calls to wait for toast notifications and updated test descriptions to include notification checks. [1] [2] [3] [4] [5]frontend/webapp/cypress/e2e/05-actions.cy.ts: AddedawaitToastfunction calls to wait for toast notifications and updated test descriptions to include notification checks. [1] [2] [3] [4] [5]frontend/webapp/cypress/e2e/06-rules.cy.ts: AddedawaitToastfunction calls to wait for toast notifications and updated test descriptions to include notification checks. [1] [2] [3] [4] [5]Modifications to constants:
frontend/webapp/cypress/constants/index.ts: Added new constants for namespace sources, data IDs for sources, and toast notifications. [1] [2] [3] [4]Minor code adjustments:
frontend/webapp/app/layout.tsx: Removed theposition: 'fixed'style fromLAYOUT_STYLE.frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-fast/sources-list/index.tsx: Addeddata-idattributes toGroupandSourceItemcomponents for better identification. [1] [2]