Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_typing.test_readonly_inheritance does not work correctly #128617

Closed
sobolevn opened this issue Jan 8, 2025 · 1 comment
Closed

test_typing.test_readonly_inheritance does not work correctly #128617

sobolevn opened this issue Jan 8, 2025 · 1 comment
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jan 8, 2025 •
edited by bedevere-app bot
Loading

Bug report

cpython/Lib/test/test_typing.py

Lines 8904 to 8921 in cdfb8bc

def test_readonly_inheritance(self):
class Base1(TypedDict):
a: ReadOnly[int]
class Child1(Base1):
b: str
self.assertEqual(Child1.__readonly_keys__, frozenset({'a'}))
self.assertEqual(Child1.__mutable_keys__, frozenset({'b'}))
class Base2(TypedDict):
a: ReadOnly[int]
class Child2(Base2):
b: str
self.assertEqual(Child1.__readonly_keys__, frozenset({'a'}))
self.assertEqual(Child1.__mutable_keys__, frozenset({'b'}))

Notice that it always tests Child1 and never Child2

Refs df4784b

I will send a PR.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir topic-typing labels Jan 8, 2025
@sobolevn sobolevn self-assigned this Jan 8, 2025
sobolevn added a commit to sobolevn/cpython that referenced this issue Jan 8, 2025
@sobolevn
pythongh-128617: Fix test_typing.test_readonly_inheritance
f76646b
@bedevere-app bedevere-app bot mentioned this issue Jan 8, 2025
Merged
sobolevn added a commit that referenced this issue Jan 8, 2025
@sobolevn
gh-128617: Fix test_typing.test_readonly_inheritance (#128618)
971a52b
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 8, 2025
@sobolevn @miss-islington
pythongh-128617: Fix test_typing.test_readonly_inheritance (pythonG…
4f7b1cc 
…H-128618)

(cherry picked from commit 971a52b)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app bedevere-app bot mentioned this issue Jan 8, 2025
Merged
sobolevn added a commit that referenced this issue Jan 8, 2025
@miss-islington @sobolevn
[3.13] gh-128617: Fix test_typing.test_readonly_inheritance (GH-128618
c0ba0bc 
) (#128622)

gh-128617: Fix `test_typing.test_readonly_inheritance` (GH-128618)
(cherry picked from commit 971a52b)

Co-authored-by: sobolevn <mail@sobolevn.me>
@sobolevn
Copy link
Member Author

sobolevn commented Jan 8, 2025

typing_extensions backport PR: python/typing_extensions#526

@sobolevn sobolevn closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn
  NODES
COMMUNITY 2
Project 5
USERS 1