Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[View] focusable flag doesn't affect clicks #5574

Open
hiiamboris opened this issue Dec 19, 2024 · 3 comments
Open

[View] focusable flag doesn't affect clicks #5574

hiiamboris opened this issue Dec 19, 2024 · 3 comments
Assignees
@dockimbel
Labels
GUI type.wish Ticket requests a new feature.

Comments

@hiiamboris
Copy link
Collaborator

Describe the bug

With the introduction of tabbing the focusable flag was added to the faces. Setting it to true for some faces affects only tabbing but not makes them focusable by clicking, which IMO is an expected UX from a focusable face.

To reproduce

  1. Run view [field "1" base "2" with [flags: 'focusable] react [print select face/parent/selected 'text]]
  2. Focus field 1 then click base 2
  3. Observe that focus is still in field 1 and no 2 line was printed on console

Expected behavior

I think focusable flag should apply to both common refocusing methods - tabbing and clicking (on-down event).

Platform version

-----------RED & PLATFORM VERSION----------- 
RED: [ branch: "master" tag: #v0.6.5 ahead: 217 date: 28-Nov-2024/20:56:25 commit: #a69159226c6885ef7e67c7c9bc50514fd49f03b2 ]
PLATFORM: [ name: "Windows 10" OS: 'Windows arch: 'x86-64 version: 10.0.0 build: 19045 ]
--------------------------------------------
@hiiamboris hiiamboris added the GUI label Dec 19, 2024
@dockimbel dockimbel self-assigned this Dec 19, 2024
@dockimbel dockimbel added the type.wish Ticket requests a new feature. label Dec 19, 2024
@greggirwin
Copy link
Contributor

A tricky thing about focus in general, is that we need some visual affordance to go with it, and we don't always have that. I don't remember if all OSs support e.g. keys for all faces either.

@greggirwin
Copy link
Contributor

For consistency, then, it's a question of whether all styles can get focus, and doc'ing these details.

@hiiamboris
Copy link
Collaborator Author

Windows allows to focus even e.g. panel, but on GTK the same trick fails. Another question is what should attempt to focus such a face do, fail silently or fail with an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dockimbel dockimbel

Labels
GUI type.wish Ticket requests a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dockimbel @greggirwin @hiiamboris
  NODES
COMMUNITY 2
Project 3
USERS 1