-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new UA style rules for overflow changes; see w3c/csswg-drafts#7144 #8028
base: main
Are you sure you want to change the base?
Conversation
Can you fill out the PR template? |
Yes, sorry, was using github.dev to make the edit and it doesn't surface that. ^_^ |
Great, thanks! Can we add UA stylesheet tests similar to web-platform-tests/wpt#33917 ? |
@tabatkins ping. |
@@ -120013,7 +120013,15 @@ legend[align=right i] { | |||
<pre><code class="css">@namespace url(http://www.w3.org/1999/xhtml); | |||
|
|||
iframe { border: 2px inset; } | |||
<span id="video-object-fit">video { object-fit: contain; }</span></code></pre> | |||
<span id="video-object-fit">video { object-fit: contain; }</span> | |||
img, video, canvas, svg:not(:root) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
svg
should be in the SVG namespace
|
Thanks Simon for working on the tests! It looks like there are no browser bugs filed for Safari or Firefox, and the one filed for Chrome is closed. However, nobody passes any of the tests currently. So, can we confirm that there is multi-implementer support for this change, and get appropriate bugs filed for it? |
cc @emilio @smfr @chrishtr for implementer interest. (Also see w3c/csswg-drafts#7144 (comment) ) |
From WebKit/standards-positions#8 (comment) it seems like this is under discussion in the CSS WG and they might end up with another solution? |
Per the resolution in w3c/csswg-drafts#7144, we're modifying the behavior of 'overflow' to actually do something on replaced elements, so they can paint outside their bounds. The necessary CSS definitions have been updated in w3c/csswg-drafts@a679cd1, but we additionally need some additions to the UA stylesheet to support it.
object-overflow
andobject-view-box
interact withoverflow
andoverflow-clip-margin
? w3c/csswg-drafts#7144 (comment) for discussion)/rendering.html ( diff )