Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new UA style rules for overflow changes; see w3c/csswg-drafts#7144 #8028

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tabatkins
Copy link
Contributor

@tabatkins tabatkins commented Jun 22, 2022

Per the resolution in w3c/csswg-drafts#7144, we're modifying the behavior of 'overflow' to actually do something on replaced elements, so they can paint outside their bounds. The necessary CSS definitions have been updated in w3c/csswg-drafts@a679cd1, but we additionally need some additions to the UA stylesheet to support it.


/rendering.html ( diff )

@domenic
Copy link
Member

domenic commented Jun 22, 2022

Can you fill out the PR template?

@tabatkins
Copy link
Contributor Author

Yes, sorry, was using github.dev to make the edit and it doesn't surface that. ^_^

@domenic
Copy link
Member

domenic commented Jun 23, 2022

Great, thanks! Can we add UA stylesheet tests similar to web-platform-tests/wpt#33917 ?

@annevk annevk added the integration Better coordination across standards needed label Jun 21, 2023
@annevk
Copy link
Member

annevk commented Jun 21, 2023

@tabatkins ping.

@@ -120013,7 +120013,15 @@ legend[align=right i] {
<pre><code class="css">@namespace url(http://www.w3.org/1999/xhtml);

iframe { border: 2px inset; }
<span id="video-object-fit">video { object-fit: contain; }</span></code></pre>
<span id="video-object-fit">video { object-fit: contain; }</span>
img, video, canvas, svg:not(:root) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

svg should be in the SVG namespace

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Jun 21, 2023
@zcorpan
Copy link
Member

zcorpan commented Jun 21, 2023

Great, thanks! Can we add UA stylesheet tests similar to web-platform-tests/wpt#33917 ?

web-platform-tests/wpt#40669

@domenic
Copy link
Member

domenic commented Jun 22, 2023

Thanks Simon for working on the tests! It looks like there are no browser bugs filed for Safari or Firefox, and the one filed for Chrome is closed. However, nobody passes any of the tests currently.

So, can we confirm that there is multi-implementer support for this change, and get appropriate bugs filed for it?

@annevk
Copy link
Member

annevk commented Jun 22, 2023

From WebKit/standards-positions#8 (comment) it seems like this is under discussion in the CSS WG and they might end up with another solution?

cc @khushalsagar

@zcorpan zcorpan added the do not merge yet Pull request must not be merged per rationale in comment label Jun 22, 2023
@whatwg whatwg deleted a comment from mitunshikder123 Jan 5, 2024
liZe added a commit to Kozea/WeasyPrint that referenced this pull request Mar 13, 2024
liZe added a commit to Kozea/WeasyPrint that referenced this pull request Mar 13, 2024
liZe added a commit to Kozea/WeasyPrint that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet Pull request must not be merged per rationale in comment integration Better coordination across standards needed topic: rendering
Development

Successfully merging this pull request may close these issues.

4 participants
  NODES
3d 1
Canvas 1
Community 2
os 13
text 1
Users 1
web 9