Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: layout visibility and constraint in Talk page thread item view #3344

Merged
merged 1 commit into from
May 19, 2022

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented May 18, 2022

Found a layout issue while working on the find-in-page function.

If you go to "GA Review" topic in `Talk: Pyramid of Sahure" you will see one of the replies does not have a username and date.

@sharvaniharan sharvaniharan merged commit 145b432 into talk-page-update-design May 19, 2022
@sharvaniharan sharvaniharan deleted the fix-layout-content branch May 19, 2022 02:31
dbrant added a commit that referenced this pull request May 31, 2022
* Distinct user and article talk pages

* Update coroutine

* adding ViewModel

* Fix dev preference option

* Bind viewmodel to talktopic page

* Add temporary usage of showing all replies

* Update sidepanel handler

* Remove talkpage provider

* Send sectionId to edit source

* Add suspend functions and update undo save function

* make sure having consistant viewmodel structure

* Fix lint

* Remove suspend functions and address code review comment

* Update posting process

* Update save logic

* Add loadTopics after saving edit

* Add seen page

* Update toolbar and tablayout

* Apply correct scrolling behavior

* Add subscribe function to viewmodel

* Add getSubscriptions

* Create viewModel in side panel correctly

* Implement new list item design

* Remove _UiState and talkPageSeenRepository

* Prevent crashes when empty content

* Makre sure sorting correctly

* Apply seen/unseen status for list item

* Adding swipe gesture

* Lint fix

* overflow menu draft

* Update overflow menu

* Fix lint

* Copy pageTitle in ViewModel to prevent overwrite the namespace

* Make sure overflow menu seen behavior works correctly

* Remove tablayout

* Update toolbar text

* Show "No subject" instead

* Create footer view layout

* Wiring up footer layout

* Refine search

* Handle views visibility correctly

* Add new sort option

* Update progressbar visibility

* Revamp talk threads. (#3282)

* First steps towards revamping talk topics.

* Wire up expanding and collapsing.

* Wire up refreshing.

* Nail down collapsing and expanding.

* Correctly parse dates.

* Wire up seen/unseen.

* Begin wiring up subscriptions.

* Correctly wire up subscriptions.

* Light cleanup.

* Fix seen/unseen.

* Introduce simple Reply activity.

* Wire up actual posting of replies.

* Correctly rebase.

* Hide subject if not new topic.

* Apply proper spacing.

* Begin wiring up Undo.

* Finish wiring up Undo.

* Introduce overflow menu for each item.

* Share correct URL.

* Implement expanding/collapsing all replies.

* Fix after merge.

* Wire up subscribe function to overflow menu

* Update overflow menu

* Fix lint

* Add lead image to talk page

* Wire up watch/unwatch behavior

* Wire in clicking of username, and a bit more cleanup.

* Update activity title on scroll.

* Update watch/unwatch menu status

* Fix undo crash

* Use request.launch for talkReplyActivity

* Make sure hide contentText when viewing article talk page

* build sha string

* Update unread swiping labels

* Update subscribe toast message

* Don't let the toolbar title jump

* Design review fixes

* Update hint

* Expand tap _target of show/hide replies.

* Expand tap _target of user name.

* Update letter spacing for button.

* Show toolbar title upon scrolling earlier.

* Update spacing between page title and thread title.

* Remember last expand/collapse selection.

* Update Save button color on state changes.

* Correctly wire up navigating to specific replies from Notifications.

* Set up LRU to store draft replies.

* Show author from last comment

* remove namespace when resetting displayText

* Add flow stats for update namespace

* Fix watchlist functions

* Put link to base article in title.

* Remove underlines from links in title text.

* Apply links and style to title views.

* Use correct fragment when sharing URL of topic.

* Update for CSRF refactor.

* Add scrollbar.

* Also catch deeplinks from section names.

* Add underscores instead of remove.

* Apply proper margin for the last comment date

* Proper image crop position and image quality

* Set correct snackbar position

* Fix: layout visibility and constraint in Talk page thread item view (#3344)

* Add user talk and talk name to the toolbar in reply activity

* Fix grey border flashes

* Update toolbar text in reply screen

* Optimize performance and rename+remove items

* Optimize performance and rename+remove items

* Use new datetime format for thread item

* Build 'Find in page' functionality for new talk pages detail page (#3343)

* Initial commit of adding find-in-page function

* Add find-in-page provider

* Remove provider

* Add searchcallbasck

* Update adapter correctly

* Add highlighting to views

* Add find in page from previous search

* Design review updates

Co-authored-by: Dmitry Brant <dbrant@wikimedia.org>

Co-authored-by: Dmitry Brant <dbrant@wikimedia.org>
Co-authored-by: Dmitry Brant <me@dmitrybrant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
  NODES
COMMUNITY 2
Project 2
USERS 1