Separates layout on complex XML for easier maintenance #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooltey
reviewed
Nov 4, 2024
| @@ -58,7 +58,7 @@ class SuggestedEditsTasksFragmentViewModel : ViewModel() { | |||
| blockMessageWikipedia = null | |||
| blockMessageWikidata = null | |||
| blockMessageCommons = null | |||
| totalContributions = 0 | |||
| totalContributions = 10 | |||
There was a problem hiding this comment.
Would it be possible to change the default value to 0?
|
Thanks @Williamrai! I really like this idea of how it simplified the layout. Can we wait until we merge the feature branch since I made some layout changes by reducing the duplicate message cards? |
Williamrai
added
the
HOLD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Separates layout on complex XML for easier maintenance
Why is this needed?
In layouts like fragment_suggested_edits_tasks we can organize the code across multiple layouts and include them as needed. This approach will simplify the process of adding new views to the UI and help maintain the design. In Contribution dashboard we needed to add new UI elements for donor history, which increased the number of lines of code. In the future if we add new designs this may result in a large amount code in a single file, making it challenging to maintain. By using separate layouts, I think we can make this process much more easier.