Add itwiki support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This intentionally doesn't add itwiki to event_streams.py yet, because it probably makes sense to let the initial import finish before enabling realtime processing. In production, this would create pickle files on the fly, on top of the heavy operation of importing the XML dumps, leading to redundancy and possibly a collision if the pickle file already exists by the time the import script gets to that article. (Completely untested theory, just playing it safe :) Bug: T270490
ragesoss
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intentionally doesn't add itwiki to event_streams.py yet, because it probably makes sense to let the initial import finish before enabling realtime processing. In production, this would create pickle files on the fly, on top of the heavy operation of importing the XML dumps, leading to redundancy and possibly a collision if the pickle file already exists by the time the import script gets to that article.
(Completely untested theory, just playing it safe :)
Bug: T270490