Page MenuHomePhabricator
Create Task
Maniphest T103489

Cursor keeps jumping to the end in sitelink editing
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
thiemowmde
Authored By
Nemo_bis
Jun 23 2015, 9:23 AM
Tags
Referenced Files
None
Subscribers
Aklapper
Bene
Nemo_bis
SJu
thiemowmde

Description

  1. Open any item with a two-words sitelink, e.g. https://www.wikidata.org/wiki/Q3524984
  2. Click edit sitelinks and type something in the middle, e.g. "Hardie" after "Thomas"

I. Observed: after each and every keystroke, the cursor goes to the end of the text area, forcing me to click the back arrow to reach the point where I need to continue.
II. Expected: the cursor shouldn't move at all.

Details

SubjectRepoBranchLines +/-
Avoid setting values that do not change in pagesuggestermediawiki/extensions/Wikibasemaster+1 -1
Don't override value in input field so that cursor doesn't jumpmediawiki/extensions/Wikibasemaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

Nemo_bis created this task.Jun 23 2015, 9:23 AM
Nemo_bis raised the priority of this task from to Needs Triage.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a project: MediaWiki-extensions-WikibaseRepository.
Nemo_bis subscribed.
Restricted Application added a project: Wikidata. · View Herald TranscriptJun 23 2015, 9:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Bene merged a task: T102360: Dodging cursor in interproject links at item pages of Wikidata.Jun 23 2015, 12:52 PM
Bene added a subscriber: SJu.
Bene subscribed.

Which browser (including version number) and os are you using?

Lydia_Pintscher triaged this task as Medium priority.Jun 24 2015, 10:30 AM
Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.
Lydia_Pintscher set Security to None.
Lydia_Pintscher added a subscriber: thiemowmde.
Nemo_bis added a comment.Jun 24 2015, 8:09 PM
In T103489#1392075, @Bene wrote:

Which browser (including version number) and os are you using?

I can reproduce with Chromium 43.0.2357.81 but not Firefox 38.0.5.

Bene added a comment.Jun 24 2015, 9:56 PM

The issue comes from this line in jquery.wikibase.pagesuggester where we set the value of the input field. I'm not sure how long this bug exists but maybe it was introduced by this change.

Commenting out the line makes the issue disappear but I'm not sure if the line is useful for something. As far as I can see everything still works as expected when removing it.

gerritbot subscribed.Jun 24 2015, 9:56 PM

Change 220630 had a related patch set uploaded (by Bene):
Don't override value in input field so that cursor doesn't jump

https://gerrit.wikimedia.org/r/220630

gerritbot added a project: Patch-For-Review.Jun 24 2015, 9:56 PM
Bene claimed this task.Jun 25 2015, 1:45 PM
Bene added a project: Wikidata-Sprint-2015-06-16.
Bene moved this task from Backlog to Review on the Wikidata-Sprint-2015-06-16 board.
gerritbot added a comment.Jun 25 2015, 3:23 PM

Change 220773 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Avoid setting values that do not change in pagesuggester

https://gerrit.wikimedia.org/r/220773

Lydia_Pintscher edited a custom field.Jun 26 2015, 11:01 AM
Lydia_Pintscher moved this task from needs discussion or investigation to consider for next sprint on the Wikidata board.Jun 26 2015, 11:15 AM
gerritbot added a comment.Jun 26 2015, 2:27 PM

Change 220630 abandoned by Bene:
Don't override value in input field so that cursor doesn't jump

Reason:
In favour of Ib0299e5

https://gerrit.wikimedia.org/r/220630

Bene closed this task as Resolved.Jun 26 2015, 2:28 PM
Bene reassigned this task from Bene to thiemowmde.
Bene moved this task from Review to Done on the Wikidata-Sprint-2015-06-16 board.
gerritbot added a comment.Jun 26 2015, 2:30 PM

Change 220773 merged by jenkins-bot:
Avoid setting values that do not change in pagesuggester

https://gerrit.wikimedia.org/r/220773

Diffusion mentioned this in rMEXT12dc90c7eba0: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jun 26 2015, 2:30 PM
thiemowmde mentioned this in rEWBAae830e105705: Avoid setting values that do not change in pagesuggester.Jun 26 2015, 2:30 PM
matej_suchanek removed a project: Patch-For-Review.Jul 8 2015, 6:23 AM
matej_suchanek removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
Note 1
Project 9