RDF mappings should be defined for all value types; overrides based on the property data type should only be used where needed. This would make it easier to add new data types that do not need a special mapping in RDF.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Register factory callbacks for value types as well as data types. | mediawiki/extensions/Wikibase | master | +292 -419 |
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Resolved | daniel | T112083 [Task] Allow RDF bindings for different data types to be registered dynamically. | ||
| Resolved | daniel | T118499 [Task] Define RDF mappings per value type | ||
| Resolved | daniel | T118497 [Task] Allow central datatype registry to also manage callbacks per value type. | ||
| Resolved | aude | T120643 Adjust WikibaseQuality external validation for changes in data type registration | ||
| · · · |
Event Timeline
Comment Actions
Change 253321 merged by jenkins-bot:
Register factory callbacks for value types as well as data types.
Comment Actions
Needs change in WikibaseQualitExternalValidation:
https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/777/console
10:10:08 1) WikibaseQuality\ExternalValidation\Tests\CrossCheck\ValueParser\ComparativeValueParserFactoryTest::testNewComparativeStringValueParser 10:10:08 Wikimedia\Assert\ParameterAssertionException: Bad value for parameter $dataTypeDefinitions[monolingualtext]: Key must start with a prefix like "PT:" or "VT:". 10:10:08 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/vendor/wikimedia/assert/src/Assert.php:63 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/lib/includes/DataTypeDefinitions.php:77 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/lib/includes/DataTypeDefinitions.php:60 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/ExternalValidation/tests/phpunit/CrossCheck/ValueParser/ComparativeValueParserFactoryTest.php:49 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/ExternalValidation/tests/phpunit/CrossCheck/ValueParser/ComparativeValueParserFactoryTest.php:22 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:137 10:10:08 10:10:08 2) WikibaseQuality\ExternalValidation\Tests\CrossCheck\ValueParser\ComparativeValueParserFactoryTest::testNewComparativeMultilingualTextValueParser 10:10:08 Wikimedia\Assert\ParameterAssertionException: Bad value for parameter $dataTypeDefinitions[monolingualtext]: Key must start with a prefix like "PT:" or "VT:". 10:10:08 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/vendor/wikimedia/assert/src/Assert.php:63 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/lib/includes/DataTypeDefinitions.php:77 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/lib/includes/DataTypeDefinitions.php:60 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/ExternalValidation/tests/phpunit/CrossCheck/ValueParser/ComparativeValueParserFactoryTest.php:49 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/ExternalValidation/tests/phpunit/CrossCheck/ValueParser/ComparativeValueParserFactoryTest.php:27 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:137 10:10:08 10:10:08 3) WikibaseQuality\ExternalValidation\Tests\CrossCheck\ValueParser\ComparativeValueParserFactoryTest::testNewComparativeValueParser 10:10:08 Wikimedia\Assert\ParameterAssertionException: Bad value for parameter $dataTypeDefinitions[monolingualtext]: Key must start with a prefix like "PT:" or "VT:". 10:10:08 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/vendor/wikimedia/assert/src/Assert.php:63 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/lib/includes/DataTypeDefinitions.php:77 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/lib/includes/DataTypeDefinitions.php:60 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/ExternalValidation/tests/phpunit/CrossCheck/ValueParser/ComparativeValueParserFactoryTest.php:49 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/ExternalValidation/tests/phpunit/CrossCheck/ValueParser/ComparativeValueParserFactoryTest.php:32 10:10:08 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:137
Comment Actions
The issue in Wikibase-Quality-External-Validation is tracked in T120643: Adjust WikibaseQuality external validation for changes in data type registration and resolved in https://gerrit.wikimedia.org/r/257505.