Page MenuHomePhabricator
Create Task
Maniphest T126944

Wikibase LanguageFallbackChainFactoryTest makes assumptions on MediaWiki's language fallback chains
Closed, ResolvedPublic
Actions

Assigned To
hoo
Authored By
MarcoAurelio
Feb 14 2016, 11:08 PM
Tags
Referenced Files
None
Subscribers
Aklapper
aude
hoo
JanZerebecki
Lydia_Pintscher
MarcoAurelio
Nikerabbit
View All 10 Subscribers

Description

Hello. Jenkins-bot complains in this change (console output). I don't know where to fix this so the uploaded patch works. Thanks.

When setting the fallback language for lzh to zh-hant, the following Wikibase test breaks:

19:08:45 There was 1 failure:
19:08:45 
19:08:45 1) Wikibase\Test\LanguageFallbackChainFactoryTest::testBuildFromBabel with data set #4 (array(array('zh-classical')), array('lzh', 'en'))
19:08:45 Failed asserting that 11 matches expected 2.
19:08:45 
19:08:45 mediawiki-extensions-hhvm/src/extensions/Wikidata/extensions/Wikibase/lib/tests/phpunit/LanguageFallbackChainFactoryTest.php:28
19:08:45 mediawiki-extensions-hhvm/src/extensions/Wikidata/extensions/Wikibase/lib/tests/phpunit/LanguageFallbackChainFactoryTest.php:246
19:08:45 mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:137

Details

SubjectRepoBranchLines +/-
Clean up hard-code language fallback chains in LanguageFallbackChainFactoryTestmediawiki/extensions/Wikibasemaster+8 -8
Hard-code language fallback chains in LanguageFallbackChainFactoryTestmediawiki/extensions/Wikibasemaster+75 -28
Fix LanguageFallbackChainFactoryTest for lzh -> zh-hant fallbackmediawiki/extensions/Wikibasemaster+9 -0
Don't fallback lzh to en, but to zh-hantmediawiki/extensions/Wikibasemaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

MarcoAurelio created this task.Feb 14 2016, 11:08 PM
MarcoAurelio claimed this task.
MarcoAurelio raised the priority of this task from to Medium.
MarcoAurelio updated the task description. (Show Details)
MarcoAurelio added a project: MediaWiki-extensions-WikibaseClient.
MarcoAurelio added subscribers: Liuxinyu970226, Nikerabbit, siebrand and 2 others.
Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 14 2016, 11:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Feb 14 2016, 11:12 PM

Change 270652 had a related patch set uploaded (by MarcoAurelio):
Don't fallback lzh to en, but to zh-hant

https://gerrit.wikimedia.org/r/270652

gerritbot added a project: Patch-For-Review.Feb 14 2016, 11:12 PM
MarcoAurelio removed MarcoAurelio as the assignee of this task.Feb 14 2016, 11:15 PM
MarcoAurelio subscribed.
MarcoAurelio added a comment.Feb 14 2016, 11:25 PM

Patch submitted don't seem to be the solution for this.

MarcoAurelio added a subscriber: Lydia_Pintscher.Feb 14 2016, 11:29 PM
gerritbot added a comment.Feb 15 2016, 2:48 PM

Change 270652 abandoned by MarcoAurelio:
Don't fallback lzh to en, but to zh-hant

https://gerrit.wikimedia.org/r/270652

MarcoAurelio renamed this task from LanguageFallbackChainFactory::FALLBACK_SELF for lzh -> zh-hant to Jenkins complains when setting fallback configuration of lzh to zh-hant.Feb 15 2016, 2:51 PM
MarcoAurelio updated the task description. (Show Details)
MarcoAurelio edited projects, added Jenkins, Continuous-Integration-Config; removed Patch-For-Review, Wikidata, MediaWiki-extensions-WikibaseClient.
MarcoAurelio set Security to None.
MarcoAurelio removed subscribers: Lydia_Pintscher, gerritbot, liangent and 4 others.

Reworded the entire task. Not sure where to have this fixed.

hashar renamed this task from Jenkins complains when setting fallback configuration of lzh to zh-hant to Wikibase test break when setting fallback configuration of lzh to zh-hant.Feb 16 2016, 8:47 AM
hashar updated the task description. (Show Details)
hashar edited projects, added Wikidata; removed Continuous-Integration-Config, Jenkins.
hashar added projects: MediaWiki-Internationalization, I18n.
hashar subscribed.

The patch is for T125373: Language fallback for Lzh (Zh-classical) should be Zh_hant.

I removed Jenkins and Continuous-Integration-Config. The problem seems to be in the Wikibase extension or some other i18n related class.

hashar unsubscribed.Feb 16 2016, 8:49 AM
Lydia_Pintscher added subscribers: Lydia_Pintscher, JanZerebecki.Feb 16 2016, 2:47 PM
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Feb 18 2016, 12:28 PM
Lydia_Pintscher added a project: Wikidata-Sprint-2016-02-16.
MarcoAurelio added subscribers: aude, hoo.Feb 22 2016, 3:58 PM

@hoo @aude - Do you know how to this this? Best regards.

hoo added a comment.Feb 22 2016, 4:04 PM
In T126944#2051305, @MarcoAurelio wrote:

@hoo @aude - Do you know how to this this? Best regards.

I'll adopt the Wikibase test to this.

gerritbot added a comment.Feb 22 2016, 4:15 PM

Change 272485 had a related patch set uploaded (by Hoo man):
Fix LanguageFallbackChainFactoryTest for lzh -> zh-hant fallback

https://gerrit.wikimedia.org/r/272485

gerritbot added a project: Patch-For-Review.Feb 22 2016, 4:15 PM
hoo claimed this task.Feb 22 2016, 4:17 PM
gerritbot added a comment.Feb 22 2016, 5:35 PM

Change 272485 abandoned by Hoo man:
Fix LanguageFallbackChainFactoryTest for lzh -> zh-hant fallback

Reason:
Per Jan: This test should probably be refactored.

https://gerrit.wikimedia.org/r/272485

hoo renamed this task from Wikibase test break when setting fallback configuration of lzh to zh-hant to Wikibase LanguageFallbackChainFactoryTest makes assumptions on MediaWiki's language fallback chains.Feb 22 2016, 5:35 PM
hoo removed hoo as the assignee of this task.
MarcoAurelio mentioned this in T125373: Language fallback for Lzh (Zh-classical) should be Zh_hant.Feb 24 2016, 4:04 PM
Lydia_Pintscher added a project: Wikidata-Sprint-2016-03-01.Mar 1 2016, 2:43 PM
Tobi_WMDE_SW subscribed.Apr 11 2016, 1:25 PM

Is this still blocking someone at the moment?

MarcoAurelio added a comment.EditedApr 11 2016, 1:53 PM
In T126944#2194735, @Tobi_WMDE_SW wrote:

Is this still blocking someone at the moment?

Yes, it's blocking a patch of mine. I was tired of waiting so I abandoned it, but if you plan to fix this I can restore the gerrit change and wait until this is fixed. See https://gerrit.wikimedia.org/r/272499

MarcoAurelio added a comment.Apr 11 2016, 2:17 PM

https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/58112/testReport/

MarcoAurelio added a comment.Jun 28 2016, 9:41 PM
21:38:04 There was 1 failure:
21:38:04 
21:38:04 1) Wikibase\Test\LanguageFallbackChainFactoryTest::testBuildFromBabel with data set #4 (array(array('zh-classical')), array('lzh', 'en'))
21:38:04 Failed asserting that 11 matches expected 2.

@Tobi_WMDE_SW Any updates here? This is blocking a site request of a project for some time now.

@aude Can some resource be assigned to fix this task?

Thank you.

Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-07-05.Jun 29 2016, 8:59 AM
Nikerabbit subscribed.Jul 21 2016, 12:05 PM
MarcoAurelio added a subscriber: siebrand.Jul 27 2016, 4:15 PM

Hi, any progress here? I've tried to bypass the test via a hack that @siebrand proposed to me but without success. Regards.

MarcoAurelio removed a project: Patch-For-Review.Jul 27 2016, 4:16 PM
Liuxinyu970226 subscribed.Aug 2 2016, 11:26 PM
gerritbot added a comment.Aug 17 2016, 9:25 PM

Change 305397 had a related patch set uploaded (by Hoo man):
Hard-code language fallback chains in LanguageFallbackChainFactoryTest

https://gerrit.wikimedia.org/r/305397

gerritbot added a project: Patch-For-Review.Aug 17 2016, 9:25 PM
hoo claimed this task.Aug 17 2016, 9:27 PM
gerritbot added a comment.Aug 18 2016, 1:52 AM

Change 305436 had a related patch set (by MarcoAurelio) published:
Fully restrict uploads on ms.wikipedia

https://gerrit.wikimedia.org/r/305436

MarcoAurelio added a comment.Aug 18 2016, 2:02 AM

Well, the above message by gerritbot is obviously unrelated to this.

gerritbot added a comment.Aug 23 2016, 7:12 PM

Change 305397 merged by jenkins-bot:
Hard-code language fallback chains in LanguageFallbackChainFactoryTest

https://gerrit.wikimedia.org/r/305397

hoo closed this task as Resolved.Aug 24 2016, 3:43 PM
hoo removed a project: Patch-For-Review.
Liuxinyu970226 unsubscribed.Aug 25 2016, 12:14 AM
Winston_Sung added a parent task: T296188: Clean up, merge, update zh/zh-* translations and update zh-related language fallback chains in mediawiki/core.Jan 15 2022, 11:34 AM
gerritbot added a comment.Jan 15 2022, 12:04 PM

Change 753955 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/extensions/Wikibase@master] Hard-code language fallback chains in LanguageFallbackChainFactoryTest

https://gerrit.wikimedia.org/r/753955

gerritbot added a project: Patch-For-Review.Jan 15 2022, 12:04 PM
Winston_Sung subscribed.Jan 15 2022, 12:04 PM

We now have the same issue when updating fallback chain for yue .

Winston_Sung reopened this task as In Progress.Jan 15 2022, 12:05 PM
Winston_Sung moved this task from Untriaged to Fallback on the I18n board.Jan 16 2022, 12:53 AM
Winston_Sung moved this task from Backlog to Language changes on the MediaWiki-Internationalization board.
gerritbot added a comment.Jan 16 2022, 5:38 AM

Change 753960 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/extensions/Wikibase@master] Clean up hard-code language fallback chains in LanguageFallbackChainFactoryTest

https://gerrit.wikimedia.org/r/753960

Winston_Sung removed a parent task: T296188: Clean up, merge, update zh/zh-* translations and update zh-related language fallback chains in mediawiki/core.Jan 16 2022, 8:25 AM
gerritbot added a comment.Jan 17 2022, 5:14 PM

Change 753960 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Clean up hard-code language fallback chains in LanguageFallbackChainFactoryTest

https://gerrit.wikimedia.org/r/753960

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 17 2022, 6:00 PM
Winston_Sung closed this task as Resolved.Jan 18 2022, 7:19 AM
Winston_Sung removed a project: Patch-For-Review.Jul 15 2023, 4:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
INTERN 3
Note 3
Project 17