When lazy loaded references is enabled:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Lazy-load references section's content when the section is expanded | mediawiki/extensions/MobileFrontend | master | +310 -100 |
I'm a little concerned with back button behaviour.
If a user toggles open the reference section, scrolls down the list and clicks a link, then clicks back do we expect them to see the references list open and themselves back at the correct link? This could be really tricky to do in a nice way without resorting to making use of localStorage :-/
We'll come back to this at the kick off meeting. The team was estimating between 2-5.
Following up from our conversation, I initially thought it would be a 5 pointer, but looking at the codebase and the API response I think it can be a 3 pointer. The reason is that besides making references show up when the user clicks on a heading of a reference section, we need also need to load and insert these references correctly when the user clicks on any other reference. Since we'll already have loaded the data, we won't need to do so upon a section heading click.
Change 293452 had a related patch set uploaded (by Bmansurov):
Lazy-load references section's content when the section is expanded
I haven't heard back from my teammates about the ongoing conversation yet. Marking as stalled for now.
I've sent an email about the cache issue. Please read it. I'm leaving the task up for grabs for now.
Seems like jenkins jobs are failing, from what I've investigated there's problems with how the modules are defined in extension.json so it seems like they are not being properly loaded, I think.
I'm happy to take over the patch once it is in a stable state.
Thanks, @Jhernandez I've fixed up the JS errors, but browser tests are still failing. I don't think they are related to the patch. I'm assigning the task to you. Hopefully, by the time you're done with your change, the testing servers will work fine.
Not sure why the browser tests are failing though. Maybe related to the webdriver bug with FF 47. Will investigate more.
@Jdlrobson I've fixed some errors with your latest PS and +1d (WFM).
I want to give it a read later to the whole commit.
Change 293452 merged by jenkins-bot:
Lazy-load references section's content when the section is expanded
To test, please visit http://reading-web-staging.wmflabs.org/wiki/Refs?mobileaction=beta on a phone sized device and click on Notes or References section.
When I visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Barack%20Obama?mobileaction=beta and click the "Notes and references" section the mobileview API shows a section body with the "View list of citations" link. This should never be returned by the API.... (and according to API link it doesn't. I think this is exposing some edge case. Can anyone else replicate this?
@Jdlrobson, yes, I see the same thing. Moreover the loaded content is not wrapped in a div. That said, I don't think we should re-open this task as we're discovering bugs with the API.
The blocker has been resolved.
URLs for testing:
http://en.m.wikipedia.beta.wmflabs.org/wiki/Refs?mobileaction=beta
and
http://en.m.wikipedia.beta.wmflabs.org/wiki/NestedRefs?mobileaction=beta