Do a code review of AJAX page watching support commit for Refreshed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SamanthaNguyen
	Sep 21 2016, 4:32 AM

Description

NOTE: @ashley requested for me to do a code review at some point in a PM during chat, creating so it won't be forgotten. :)

https://gerrit.wikimedia.org/r/#/c/304597/

There was either a CSS issue / HTML issue with this commit, where one of the list items wasn't being wrapped up thus causing the WikiFont to be misaligned, along with the list item itself (if I remember correctly). Note to self - check out the commit which is available on social-tools.wmflabs.org (for testing it out) and see if this is still true, and then let's figure out how to solve it. :)

Event Timeline

SamanthaNguyen created this task.Sep 21 2016, 4:32 AM

SamanthaNguyen moved this task from Backlog to Feedback on the Refreshed board.

SamanthaNguyen moved this task from Backlog to Refreshed on the Brickimedia board.

@ashley Could you put that WIP commit live on social-tools.wmflabs.org so it can be tested live? thanks :)

In T146252#2664567, @SamanthaNguyen wrote:

@ashley Could you put that WIP commit live on social-tools.wmflabs.org so it can be tested live? thanks :)

{{done}}

It was actually live earlier today, then I temporarily reverted it and forgot to put it back.

Ah didn't know that, makes sense :) thanks!

So, looks like the <span class="toolbox-item-text">...</span> isn't being wrapped around the actual toolbox item text for the watch item.

As of Refreshed 4, the watch button is no longer inside a dropdown, so I think this issue is resolved. Feel free to reopen it if you have more thoughts.

Restricted Application added a subscriber: MacFan4000. · View Herald TranscriptJan 5 2020, 10:51 PM

Aklapper removed a subscriber: Brickimedia.May 16 2023, 10:26 AM

	F4521076: pasted_file
	Sep 24 2016, 7:29 PM

Do a code review of AJAX page watching support commit for RefreshedClosed, ResolvedPublicActions

Description

Event Timeline

Do a code review of AJAX page watching support commit for Refreshed
Closed, ResolvedPublic
Actions