Page MenuHomePhabricator
Create Task
Maniphest T157084

Mobile context in nested situations (e.g. link context inside a reference) is hopelessly broken
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To
matmarex
Authored By
Ryasmeen
Feb 2 2017, 11:06 PM
Tags
Referenced Files
F5458391: Screen Shot 2017-02-02 at 11.01.56 PM.png
Feb 2 2017, 11:06 PM
Subscribers
Aklapper
Esanders
gerritbot
Jdforrester-WMF
Ryasmeen

Description

Steps to reproduce:

  1. Open Mobile VE
  2. Add a basic reference
  3. Inside the basic reference dialog, insert a link
  4. Click on the link node that you just added

Observed Result:
The context menu for the link is appearing completely broken

Screenshot:

Screen Shot 2017-02-02 at 11.01.56 PM.png (481×1 px, 42 KB)

Details

SubjectRepoBranchLines +/-
Fix context menu for mobile _targetWidgetsmediawiki/extensions/VisualEditormaster+15 -0
Update VE core submodule to master (b04645ac8)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui._targetWidget: Emit an event to allow last-minute setupVisualEditor/VisualEditormaster+8 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Feb 2 2017, 11:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2017, 11:06 PM
Jdforrester-WMF renamed this task from UI for link inspector context menu inside reference dialog is broken in Mobile VE to [Regression] Mobile context in nested situations (e.g. link context inside a reference) is hopelessly broken.Feb 6 2017, 7:13 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to Epics on the VisualEditor board.

Probably broken with the recent desktop/mobile code convergence.

Esanders renamed this task from [Regression] Mobile context in nested situations (e.g. link context inside a reference) is hopelessly broken to Mobile context in nested situations (e.g. link context inside a reference) is hopelessly broken.May 10 2017, 9:58 AM
Esanders lowered the priority of this task from High to Medium.

I don't think this has ever worked, as we've never worked on the mobile toolbar and context in _target widgets.

matmarex claimed this task.Dec 30 2017, 3:23 AM
matmarex added a subscriber: Esanders.
gerritbot subscribed.Dec 30 2017, 3:23 AM

Change 400955 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui._targetWidget: Emit an event to allow last-minute setup

https://gerrit.wikimedia.org/r/400955

gerritbot added a project: Patch-For-Review.Dec 30 2017, 3:23 AM

Change 400957 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Fix context menu for mobile _targetWidgets

https://gerrit.wikimedia.org/r/400957

gerritbot added a comment.Jan 4 2018, 2:37 PM

Change 400955 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui._targetWidget: Emit an event to allow last-minute setup

https://gerrit.wikimedia.org/r/400955

gerritbot added a comment.Jan 4 2018, 4:53 PM

Change 402079 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b04645ac8)

https://gerrit.wikimedia.org/r/402079

gerritbot added a comment.Jan 4 2018, 6:49 PM

Change 402079 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b04645ac8)

https://gerrit.wikimedia.org/r/402079

gerritbot added a comment.Jan 4 2018, 6:50 PM

Change 400957 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix context menu for mobile _targetWidgets

https://gerrit.wikimedia.org/r/400957

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 4 2018, 7:01 PM
Ryasmeen closed this task as Resolved.Jan 4 2018, 9:36 PM
Ryasmeen edited projects, added Verified; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 4 2018, 9:36 PM
Jdforrester-WMF changed the point value for this task from 1 to 8.Jan 31 2018, 4:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
Note 3
Project 4