"ParseError: Unrecognised input in ../mmv.mixins.less" (due to unescaped input?)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Alexia
	Jan 9 2018, 5:49 PM

Description

Using the Lessoid/Less 2.7.2 drop in: https://github.com/HydraWiki/lessoid

ParseError: Unrecognised input in ../mmv.mixins.less on line 42, column 65:
41 /* stylelint-disable number-no-trailing-zeros */
42 filter: progid:DXImageTransform.Microsoft.BasicImage( rotation=( @degrees / 90.0 ) );
43 -ms-filter: 'progid:DXImageTransform.Microsoft.BasicImage( rotation=( @degrees / 90.0 ) )';

I fixed it by escaping the input per Less documentation, but I am unsure if this will work with MediaWiki's default outdated Less.php implementation.

	filter: e("progid:DXImageTransform.Microsoft.BasicImage( rotation=(") @degrees / 90.0 e(") )");
	-ms-filter: e("'progid:DXImageTransform.Microsoft.BasicImage( rotation=(") @degrees / 90.0 e(") )'");

Which produces:

/* stylelint-disable number-no-trailing-zeros */
filter: progid:DXImageTransform.Microsoft.BasicImage( rotation=( -0.5deg ) );
-ms-filter: 'progid:DXImageTransform.Microsoft.BasicImage( rotation=( -0.5deg ) )';

Details

	Subject	Repo	Branch	Lines +/-
	Drop CSS hacks for unsupported browsers (IE<11, ancient Firefox)	mediawiki/extensions/MultimediaViewer	master	+1 -20
	Adjust one MSIE-specific filter syntax to fix parse error like the others	mediawiki/extensions/MultimediaViewer	master	+2 -2

Customize query in gerrit

Event Timeline

Alexia created this task.Jan 9 2018, 5:49 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptJan 9 2018, 5:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Aklapper renamed this task from The mmv.mixins.less file has a syntax error. to "ParseError: Unrecognised input in ../mmv.mixins.less" (due to unescaped input?).Jan 10 2018, 11:52 AM

• 238482n375 set Security to Software security bug.Jun 15 2018, 8:07 AM

• 238482n375 added a project: acl*security.

• 238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".

• 238482n375 subscribed.

This comment was removed by akosiaris.

akosiaris removed a project: acl*security.Jun 15 2018, 10:46 AM

akosiaris changed the visibility from "Custom Policy" to "Public (No Login Required)".

akosiaris removed a subscriber: • 238482n375.

akosiaris subscribed.

Restricted Application added a project: acl*security. · View Herald TranscriptJun 15 2018, 10:47 AM

akosiaris removed a project: acl*security.Jun 15 2018, 10:47 AM

Change 468383 had a related patch set uploaded (by Alexia; owner: Alexia):
[mediawiki/extensions/MultimediaViewer@master] T184543: This fixes the parse error.

https://gerrit.wikimedia.org/r/468383

gerritbot added a project: Patch-For-Review.Oct 18 2018, 6:46 PM

Change 468383 had a related patch set uploaded (by Jforrester; owner: Alexia):
[mediawiki/extensions/MultimediaViewer@master] Adjust one MSIE-specific filter syntax to fix parse error like the others

https://gerrit.wikimedia.org/r/468383

Change 526156 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MultimediaViewer@master] Drop CSS hacks for unsupported browsers (IE<11, ancient Firefox)

https://gerrit.wikimedia.org/r/526156

Change 468383 abandoned by Esanders:
Adjust one MSIE-specific filter syntax to fix parse error like the others

Reason:
See Ibd07ecd545f9b69f4dd3adb2b371b4d87ca4098b

https://gerrit.wikimedia.org/r/468383

Change 526156 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Drop CSS hacks for unsupported browsers (IE<11, ancient Firefox)

https://gerrit.wikimedia.org/r/526156

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 29 2019, 10:00 PM

• Demian moved this task from Backlog to Needs Analysis on the MediaViewer board.Nov 2 2020, 2:29 AM

• Demian closed this task as Resolved.Nov 2 2020, 2:34 AM

• Demian claimed this task.

• Demian removed a project: Patch-For-Review.

• Demian moved this task from Needs Analysis to In Process on the MediaViewer board.

Alexia unsubscribed.Nov 2 2020, 2:35 AM

Nope, I did not claim the task. Ed submitted the patch.

"ParseError: Unrecognised input in ../mmv.mixins.less" (due to unescaped input?)Closed, ResolvedPublicActions

Description

Details

Event Timeline

"ParseError: Unrecognised input in ../mmv.mixins.less" (due to unescaped input?)
Closed, ResolvedPublic
Actions