Some communities have expressed interest in more testing. Currently this can be done with the URL param 'visualdiff', but allowing users to enable a BF would generate more feedback and failing test cases.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T105173 HTML diffs of edits for everything | |||
| Resolved | None | T167508 Visual diff: Make VE visual diffs available for historical diffs via MediaWiki's DiffView page | |||
| Resolved | Esanders | T185708 Make historical VisualDiffs a BetaFeature | |||
| Resolved | Esanders | T190706 Historical visual differences beta feature information page needs updating to mention historical diffs as well as diffs in the editors |
Event Timeline
Comment Actions
Change 406250 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] VisualDiffs: Create an optional BetaFeature for historical diffs
Comment Actions
Any reason the visualdiff content adds 15px of left margin ? It's a bit jarring for historical diffs, as it messes with the alignment in the view, which gives it a more 'busy' look then needed.
Any reason the visualdiff content adds 15px of left margin ? It's a bit jarring for historical diffs, as it messes with the alignment in the view, which gives it a more 'busy' look then needed.
.ve-ui-diffElement-content {
left-margin: 15px;
}Comment Actions
Change 406250 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] VisualDiffs: Create an optional BetaFeature for historical diffs
Comment Actions
Any reason the visualdiff content adds 15px of left margin ? It's a bit jarring for historical diffs, as it messes with the alignment in the view, which gives it a more 'busy' look then needed.
To my knowledge, there is no particular reason it is this way. I agree it should be changed.
Comment Actions
Code's merged and will ride next week's train, all that's needed now is a config patch to enable.
Comment Actions
I added an item to next week's Tech News. I have no idea whether I did it right. Perhaps @Johan can tell me if I need to change something? :-)
Comment Actions
@Quiddity is handling Tech News this particular week, so any questions about this issue should go to him. (:
Comment Actions
I added a link to your line on TN: https://www.mediawiki.org/wiki/VisualEditor/Diffs though could use a mention of where to find the BF etc., if not a more general update at some point :) TY!
Comment Actions
Change 409091 had a related patch set uploaded (by Zfilipin; owner: Jforrester):
[operations/mediawiki-config@master] Enable the visual diff beta feature
Comment Actions
Change 409091 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable the visual diff beta feature
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-02-15T14:53:42Z] <zfilipin@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:409091|Enable the visual diff beta feature (T185708)]] (duration: 01m 12s)
Comment Actions
I tried to get this SWAT deployed today, but the beta feature didn't appear after the patch was deployed. Something appears to be missing, but I have no idea what. This is what happens when a non-engineer tries to do engineering things.
Comment Actions
Looking at https://gerrit.wikimedia.org/r/#/c/406250/5/VisualEditor.hooks.php this might need 1 more config change to enable it on a wiki.
addshore@tin:/srv/mediawiki-staging$ mwscript eval.php --wiki testwiki > var_dump($wgVisualEditorEnableDiffPageBetaFeature); bool(false)
Comment Actions
My fault, yeah, we need to set wgVisualEditorEnableDiffPageBetaFeature true on wikis where you want it. Did you still want it to go everywhere? Just test wikis? Just Wikipedias?
Comment Actions
Change 411048 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Follow-up 77be427a1: Enable the Beta Feature on all wikis
Comment Actions
Change 411048 merged by jenkins-bot:
[operations/mediawiki-config@master] Follow-up 77be427a1: Enable the Beta Feature on all wikis
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-02-15T19:55:49Z] <thcipriani@tin> Synchronized wmf-config/CommonSettings.php: SWAT: Follow-up 77be427a1: [[gerrit:411048|Enable the Beta Feature on all wikis]] T185708 (duration: 01m 12s)