Page MenuHomePhabricator

Search suggestions not working in mobile skin
Closed, ResolvedPublic

Description

Search suggestions are not working in the mobile version of the Refreshed skin when using the virtual keyboard. Tested on two Android phones.

This is the case on Brickipedia and Coasterpedia. The search suggestions appear to work fine on Flat Earth Wiki which uses an older version of MediaWiki and the skin

Event Timeline

@lachlan Are you still able to reproduce this on Brickipedia? As far as I can see, search suggestions are working there just fine (see screenshot). Tested on a Nokia X using Firefox for Mobile (Fennec) 51.0.

Do note that Brickipedia isn't using the newest version of MediaWiki nor the Refreshed skin currently, but that'll change once MediaWiki 1.31 is out and we'll have updated the site to that version.

cc @SamanthaNguyen

Screenshot.png (800×480 px, 75 KB)

This comment was removed by lachlan.

I've just tested it again and unfortunately neither Bricki or Coasterpedia search suggestions are working on a Moto G5S Plus running Nougat and a Moto G2 running Marshmallow. The search suggestions are working on my iPad in both mobile sized and desktop sized windows. I remember the suggestions did work if I plugged my phone into my computer in debug mode and used my computer keyboard to type.

coasterpedia.net is running 1.30 and refreshed skin version 1.3.2 which isn't the latest version so I will update it in a couple of days time. However that doesn't expalin why it's not working on Bricki. Maybe it's a problem with newer versions of Android? I will have to test it on some more devices.

For debugging: Can you try this with another skin such as Vector to see if search suggestions still don't work? Thanks.

The search suggestions are not working on any skin on both websites. They work perfectly if I plug a USB keyboard into my device and type out the search, however they are not working with the virtual keyboard.

I'm afraid I have no Idea what is causing it to not work

Tested this with an Android KitKat device (since currently it's the newest "official" Android device I have) using Fennec 47.0:

  • Search suggestions on Brickipedia are working, even if somewhat hard to use (e.g. you type "41" and it lists "410", "410 Payloader", "410 payloader", "4100", "4100 Maximum Wheels", "4100 maximum wheels" -- the last four suggestions, "41000", "41000 Andrea's Jetski", "41000 Jet Ski" and "4100 Jetski", simply aren't visible on mobile "thanks" to the virtual keyboard obscuring them); considerably harder to use in landscape mode than in portrait mode; in landscape mode only the first suggestion ("410") is fully visible, the second one is already half-obscured by the virtual keyboard
  • On Coasterpedia it looks like header#header-wrapper has a higher z-index than div.suggestions; giving div.suggestions a z-index of 10000 or greater fixes this issue and makes the search suggestions completely visible (on desktop). Fascinatingly enough it looks initially as if the search suggestions aren't working at all in portrait mode on mobile -- typing some text doesn't seem to do anything although it would appear that the search suggestions are indeed fetched but for whatever reason they don't seem to be in the viewport or something. Flipping the device into landscape position shows that the functionality at least partially works.

@lachlan, what browsers did you use to test this? I'm wondering if the issues described in this ticket are more prominent in e.g. Chromium-based browsers than in other browsers (since I believe that Apple doesn't allow non-Safari-based browsers to be installed on iDevices, and as my tests proved, Firefox is affected but not as much as your Android browsers).

Hi @ashley

I've tested the search suggestions and they are working on Brickipedia on Firefox 60, but not on Chrome 66. My phone is running Android Nougat. Do you have the latest version of Chrome on your Android? As you say still not working in either on Coasterpedia - will have to investigate that further.

The suggestions are working fine in the mobile view on Safari on my iPad running iOS 11

@lachlan Hi! This may be resolved in Refreshed 4. Is it occurring on BS01? Also, if you upgrade Coasterpedia to Refreshed 4 and it's still an issue, please let us know.

Hello, @MtMNC!

I will look into updating the site and get back to you on this. I've tested it on BS01 and it's still not working on Firefox, Samsung Browser, or Chrome on a Samsung S9+.

Are they working for you? Perhaps I am doing something wrong with my phone. For whatever reason, the Flat Earth Wiki suggestions are not working for me as of today.

Lachlan

Interesting. I'm limited to testing on iOS, but it's worked for me on both Safari and Firefox. By any chance do you have JS disabled? It looks like the Flat Earth Wiki hasn't upgraded their skin for a while, so if search suggestions recently stopped working on your phone it may be a setting on your end.

Hi everyone, I've updated to Refreshed 4 on Coasterpedia, and removed a bunch of CSS, and the search suggestions are working. Looking at BS01 for a second time it would appear search results are working, but rather intermittently. I think this was the issue before - they have been working, just very slowly.

Thanks for all your help

  NODES
debugging 1
HOME 1
Idea 1
idea 1
Interesting 1
iOS 2
mac 2
Note 2
os 6
text 1
web 1