Page MenuHomePhabricator
Create Task
Maniphest T192303

Advanced Search & Timeless: General
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
None
Authored By
• Tonina_Zhelyazkova_WMDE
Apr 16 2018, 4:13 PM
Tags
Referenced Files
F17011436: AS_timeless.png
Apr 16 2018, 4:13 PM
F17011437: AS_timeless_infobox.png
Apr 16 2018, 4:13 PM
Subscribers
Aklapper
• aniansson
Charlie_WMDE
gabriel-wmde
gerritbot
• Lea_WMDE
Mooeypoo
View All 11 Subscribers

Description

Problems:

  • "Exactly this text" field appears smaller (in height) than the others
  • The space between "Not these words" and "One of these words" is different than the space between the other fields
  • There are some empty rectangular forms ( placeholders? ) inside "These words", "Not these words", "One of these words" and "Only pages with this template", see T189949. Fixed via https://gerrit.wikimedia.org/r/422412, see T189950.
  • Infobox content looks strange, it appears to have different fonts for different parts of the text
  • The file-size boxes problem is addressed here T189950, and also seems to have a patch up already.
  • The word "Search" inside the search button looks blurry. It's probably because the font has too little space between the letters.

AS_timeless_infobox.png (656×508 px, 39 KB)

AS_timeless.png (565×856 px, 30 KB)

Task
Spend an hour to try and see how much of that we can and should fix on our side. If we can do painless workarounds, yay! If this should actually be tackled somewhere else, please create the necessary tickets.

Details

SubjectRepoBranchLines +/-
Timeless: Remove inconsistent resets on <code> elementsmediawiki/extensions/AdvancedSearchmaster+1 -6
Do not set CSS values via (expensive) JavaScriptmediawiki/extensions/AdvancedSearchmaster+13 -13
Remove redundant CSS values on <code> elementsmediawiki/extensions/AdvancedSearchmaster+1 -3
Remove `text-shadow` from progressive mediawiki.ui buttonsmediawiki/skins/Timelessmaster+5 -1
TagMultiselectWidget: Reset more styles on invisible <input>oojs/uimaster+3 -0
Fix general issues in the Timeless skinmediawiki/extensions/AdvancedSearchmaster+30 -4
Reset box-shadow on customized <fieldset>mediawiki/extensions/AdvancedSearchmaster+1 -0
Make Timeless aware of OOUI multiselect widgetsmediawiki/skins/Timelessmaster+19 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.Apr 16 2018, 4:13 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptApr 16 2018, 4:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Tonina_Zhelyazkova_WMDE added a project: Timeless.Apr 16 2018, 4:14 PM
• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)Apr 24 2018, 2:33 PM
• Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Advanced-Search board.Apr 25 2018, 11:57 AM
• Lea_WMDE set the point value for this task to 2.Apr 25 2018, 12:20 PM

this estimation is about "taking a look", creating tickets if this should be fixed outside of our scope, and including medium term workarounds, if they are easy to add and remove.

• Lea_WMDE added a subtask: T189949: Advanced search & Timeless-Skin: Faint Boxes.Apr 25 2018, 1:59 PM
• Lea_WMDE added a subtask: T189950: Advanced Search & Timeless: misaligned file-size entry boxes.Apr 25 2018, 2:01 PM
• Lea_WMDE updated the task description. (Show Details)Apr 25 2018, 2:05 PM
• Lea_WMDE triaged this task as Medium priority.Apr 25 2018, 2:07 PM
• Lea_WMDE updated the task description. (Show Details)
kai.nissen added a project: WMDE-FUN-Sprint-2018-05-02.May 2 2018, 1:07 PM
• aniansson claimed this task.May 9 2018, 9:38 AM
• aniansson moved this task from Todo to Doing on the WMDE-FUN-Sprint-2018-05-02 board.
Charlie_WMDE moved this task from Tickets ready for pickup to In FUN sprint on the Advanced-Search board.May 9 2018, 10:56 AM
• Lea_WMDE mentioned this in T194508: Synching Timeless, AdvancedSearch and OOUI.May 11 2018, 2:33 PM
gerritbot subscribed.May 14 2018, 11:31 AM

Change 432975 had a related patch set uploaded (by Ebba Aniansson; owner: Ebba Aniansson):
[mediawiki/extensions/AdvancedSearch@master] Fix general issues in the Timeless skin

https://gerrit.wikimedia.org/r/432975

gerritbot added a project: Patch-For-Review.May 14 2018, 11:31 AM
• aniansson mentioned this in rEASR6e1ba09ce4c2: Fix general issues in the Timeless skin.May 14 2018, 11:32 AM
thiemowmde closed subtask T189949: Advanced search & Timeless-Skin: Faint Boxes as Resolved.May 14 2018, 12:05 PM
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Incoming to Advanced Search on the TCB-Team (now WMDE-TechWish) board.
thiemowmde subscribed.
• aniansson added a project: User-aniansson.May 14 2018, 12:51 PM
• aniansson moved this task from Backlog to Doing on the User-aniansson board.
• aniansson mentioned this in rEASR1a5bc50db6b3: Fix general issues in the Timeless skin.May 14 2018, 1:46 PM
• aniansson mentioned this in rEASR24d517a9b426: Fix general issues in the Timeless skin.May 15 2018, 11:14 AM
thiemowmde closed subtask T189950: Advanced Search & Timeless: misaligned file-size entry boxes as Resolved.May 15 2018, 12:44 PM
gerritbot added a comment.May 15 2018, 12:50 PM

Change 433150 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[oojs/ui@master] TagMultiselectWidget: Reset more styles on invisible <input>

https://gerrit.wikimedia.org/r/433150

thiemowmde added a project: OOUI.May 15 2018, 12:58 PM
thiemowmde added subscribers: Volker_E, Mooeypoo.

For your information, I uploaded an upstream OOUI patch at https://gerrit.wikimedia.org/r/433150.

  • It removes the box-shadow I already removed via https://gerrit.wikimedia.org/r/422412. The additional box-shadow: 0 in the AdvancedSearch .less file can be removed when the fix is in OOUI.
  • The same patch also fixes the issue that some input fields appear higher than others.

Still to do:

  • The blurry "Search" label on the button should also be fixed upstream in OOUI, in my opinion. I did not investigated this one yet.
  • From what I see the different fonts should be fixed in AdvancedSearch. https://gerrit.wikimedia.org/r/432975 already does this.
  • I'm not sure what causes the different spacing between fields.
gerritbot added a comment.May 18 2018, 9:13 PM

Change 433906 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/skins/Timeless@master] Make Timeless aware of OOUI multiselect widgets

https://gerrit.wikimedia.org/r/433906

gerritbot added a comment.May 18 2018, 10:12 PM

Change 433906 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Make Timeless aware of OOUI multiselect widgets

https://gerrit.wikimedia.org/r/433906

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 18 2018, 11:00 PM
gerritbot added a comment.May 19 2018, 8:21 AM

Change 433925 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Reset box-shadow on customized <fieldset>

https://gerrit.wikimedia.org/r/433925

thiemowmde mentioned this in rEASR99fc87880f4b: Reset box-shadow on customized <fieldset>.May 19 2018, 8:23 AM
gerritbot added a comment.May 22 2018, 10:55 AM

Change 433925 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Reset box-shadow on customized <fieldset>

https://gerrit.wikimedia.org/r/433925

• Tonina_Zhelyazkova_WMDE mentioned this in rEASRf6ea5a3db55c: Fix general issues in the Timeless skin.May 22 2018, 1:50 PM
• Tonina_Zhelyazkova_WMDE removed • aniansson as the assignee of this task.May 22 2018, 2:04 PM
• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)
• Tonina_Zhelyazkova_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-05-02 board.
Mooeypoo added a comment.May 23 2018, 9:09 AM

This is great, thanks!

Please continue flagging more issues you encounter with OOUI and Timeless, we should continue adjusting those as we see them, like we do for vector and monobook (...and sometimes, <sigh> Modern)

gerritbot added a comment.May 23 2018, 12:20 PM

Change 432975 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Fix general issues in the Timeless skin

https://gerrit.wikimedia.org/r/432975

• Tonina_Zhelyazkova_WMDE moved this task from Review to Deploy to Test on the WMDE-FUN-Sprint-2018-05-02 board.May 23 2018, 12:22 PM
• Tonina_Zhelyazkova_WMDE moved this task from Deploy to Test to Test on the WMDE-FUN-Sprint-2018-05-02 board.May 23 2018, 12:27 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)); removed MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 23 2018, 1:00 PM
• Lea_WMDE added a comment.May 25 2018, 10:28 AM

So the contents of this ticket looks great! Only I don't manage to get any category or template suggestions right now, with both fields behaving differently (there is a striped background for the category field, that does not seem to go away, and just nothing for the template field). So Im not sure if new bugs were introduced with this one - on the live version there are no problems.
(Or I did not manage to hit any key that actually is the start of a category/template)

• Tonina_Zhelyazkova_WMDE added a comment.May 25 2018, 11:34 AM

@Lea_WMDE on uca there are categories starting with the letters M or F. As of templates, there's one named "Erster Test"

• Lea_WMDE added a comment.May 25 2018, 1:01 PM

Thanks, I got it now. It is suuuper slow, but I'm guessing this is a test wiki issue.

• Lea_WMDE moved this task from Test to Done on the WMDE-FUN-Sprint-2018-05-02 board.May 25 2018, 1:02 PM
gerritbot added a comment.May 28 2018, 8:17 AM

Change 435734 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Remove redundant CSS values on <code> elements

https://gerrit.wikimedia.org/r/435734

thiemowmde mentioned this in rEASR51189566fb90: Remove redundant CSS values on <code> elements.May 28 2018, 8:19 AM
gerritbot added a comment.May 28 2018, 8:21 AM

Change 435735 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Timeless: Remove inconsistent resets on <code> elements

https://gerrit.wikimedia.org/r/435735

thiemowmde mentioned this in rEASR3ef0086e994e: Timeless: Remove inconsistent resets on <code> elements.May 28 2018, 8:23 AM
gerritbot added a comment.May 28 2018, 8:38 AM

Change 435736 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Do not set CSS values via (expensive) JavaScript

https://gerrit.wikimedia.org/r/435736

thiemowmde mentioned this in rEASR18b1bb3eed7d: Do not set CSS values via (expensive) JavaScript.May 28 2018, 8:41 AM
Volker_E removed a project: OOUI.EditedMay 28 2018, 8:36 PM

@thiemowmde the “blurred” Search label originates in a text-shadow on progressive .mw-ui-button in Timeless forms.less, which I don't have an explanation why it's there. Not an OOUI issue.

gerritbot added a comment.May 28 2018, 8:38 PM

Change 435836 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Timeless@master] Remove text-shadow from progressive mediawiki.ui buttons

https://gerrit.wikimedia.org/r/435836

gerritbot added a comment.May 29 2018, 11:28 AM

Change 433150 abandoned by Thiemo Kreuz (WMDE):
TagMultiselectWidget: Reset more styles on invisible <input>

Reason:
I still argue for the box-shadow, because I know there are browsers out there (Safari? Chrome?) that set some kind of box-shadow on <input>s by default. But I don't have the time to find that browser. The specific issue that made me work on this is now fixed in the Timeless skin.

https://gerrit.wikimedia.org/r/433150

gerritbot added a comment.May 29 2018, 12:26 PM

Change 435836 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Remove text-shadow from progressive mediawiki.ui buttons

https://gerrit.wikimedia.org/r/435836

• Lea_WMDE closed this task as Resolved.May 30 2018, 10:35 AM
Krinkle mentioned this in rEASR555ae11f3a16: Remove redundant CSS values on <code> elements.May 31 2018, 6:57 PM
gerritbot added a comment.Jun 5 2018, 4:06 PM

Change 435734 merged by Thiemo Kreuz (WMDE):
[mediawiki/extensions/AdvancedSearch@master] Remove redundant CSS values on <code> elements

https://gerrit.wikimedia.org/r/435734

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)); removed MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).Jun 5 2018, 5:00 PM
thiemowmde mentioned this in rEASRafb2ffe4423e: Do not set CSS values via (expensive) JavaScript.Jun 6 2018, 3:03 PM
Krinkle mentioned this in rEASR4100e149b2b9: Timeless: Remove inconsistent resets on <code> elements.Jun 6 2018, 6:36 PM
gerritbot added a comment.Jun 14 2018, 12:37 PM

Change 435736 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Do not set CSS values via (expensive) JavaScript

https://gerrit.wikimedia.org/r/435736

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 14 2018, 1:00 PM
thiemowmde mentioned this in rEASR3e4b4dc7f7f9: Timeless: Remove inconsistent resets on <code> elements.Jun 14 2018, 1:26 PM
gerritbot added a comment.Jun 14 2018, 1:48 PM

Change 435735 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Timeless: Remove inconsistent resets on <code> elements

https://gerrit.wikimedia.org/r/435735

thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
Bugs 1
Note 9
Project 12
todo 1