Maniphest T194090

Add Phan tests for TorBlock
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MarcoAurelio
	May 7 2018, 9:49 PM

Tags

Referenced Files

None

Subscribers

Description

TorBlock would benefit from Phan and taint-checks IMHO. I'll try to get them installed.

Details

	Subject	Repo	Branch	Lines +/-
	Add Phan tests for TorBlock	mediawiki/extensions/TorBlock	master	+21 -1

Customize query in gerrit

Event Timeline

MarcoAurelio created this task.May 7 2018, 9:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2018, 9:49 PM

Change 431665 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/TorBlock@master] Add Phan tests for TorBlock

https://gerrit.wikimedia.org/r/431665

gerritbot added a project: Patch-For-Review.May 7 2018, 9:59 PM

Two failures only:

includes/TorBlockHooks.php

<error line="141" severity="warning" message="Parameter of undeclared type \AbuseFilterVariableHolder" source="PhanUndeclaredTypeParameter"/>
<error line="142" severity="error" message="Call to method setVar from undeclared class \AbuseFilterVariableHolder" source="PhanUndeclaredClassMethod"/>

MarcoAurelio triaged this task as Medium priority.May 10 2018, 9:30 AM

Change 431665 merged by jenkins-bot:
[mediawiki/extensions/TorBlock@master] Add Phan tests for TorBlock

https://gerrit.wikimedia.org/r/431665

Legoktm closed this task as Resolved.May 29 2018, 1:03 AM

Legoktm assigned this task to MarcoAurelio.

Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptMay 29 2018, 1:03 AM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 29 2018, 2:00 AM

MarcoAurelio moved this task from unsorted/backlog to cabinet on the User-MarcoAurelio board.Jun 1 2018, 10:18 AM

• Vvjjkkii renamed this task from Add Phan tests for TorBlock to xfdaaaaaaa.Jul 1 2018, 1:11 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed MarcoAurelio as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, MarcoAurelio, Aklapper.

CommunityTechBot renamed this task from xfdaaaaaaa to Add Phan tests for TorBlock.Jul 2 2018, 1:38 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to MarcoAurelio.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, MarcoAurelio, Aklapper.

NODES