Page MenuHomePhabricator
Create Task
Maniphest T204031

Deploy regular running of wikidata constraint checks using the job queue
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Ladsgroup
Authored By
Addshore
Sep 11 2018, 9:16 AM
Tags
Referenced Files
F34085932: constraints-job-insertion-rate.png
Feb 2 2021, 4:19 PM
F28085065: image.png
Jan 31 2019, 3:08 PM
F28003670: image.png
Jan 23 2019, 11:52 AM
F27988359: image.png
Jan 22 2019, 10:39 AM
F27988370: image.png
Jan 22 2019, 10:39 AM
F27927914: image.png
Jan 17 2019, 5:46 PM
Subscribers
Addshore
Aklapper
• alaa_wmde
Gehel
gerritbot
Ladsgroup
Lucas_Werkmeister_WMDE
View All 15 Subscribers
Tokens
"Stroopwafel" token, awarded by Daniel_Mietchen.

Description

Once T204022 is done and merged and deployed we can think about deploying the feature:

The feature should have a staged roll out, slowly ramping up the number of edits that the jobs are run for.
Throughout the time of the roll out metrics such as number of jobs in the queue etc should be monitored.
Throughout the rollout we also need to check the cache status and cache eviction rate, we probably can't fit results for all entities in the cache..
The job will only really take full effect when T204024 is also done persistently storing the data.

The config option was introduced in https://gerrit.wikimedia.org/r/#/c/463950/
The config options is wgWBQualityConstraintsEnableConstraintsCheckJobsRatio

Beta and test can probably be deployed quickly / in the same day (if everything goes fine).
wikidata.org should probably not proceed any faster than 1 increase per day.

Deployment List:

  • beta wikidata 100% - 16th Jan 2019
  • testwikidata 50% - 16th Jan 2019
  • testwikidata 100% - 16th Jan 2019
  • wikidata.org 1% - 16th Jan 2019
  • wikidata.org 5% - 17th Jan 2019
  • wikidata.org 10% - 22nd jan EU Morning 2019
  • wikidata.org 25% - 22nd jan EU Morning 2019
  • wikidata.org 40% - 1st Feb 2021
  • wikidata.org 50% - 11th Feb 2021
  • wikidata.org 60% - 12th Apr 2021
  • wikidata.org 70% - 3rd May 2021

...

  • wikidata.org 100%

When deploying and expecting a rate of around 10 jobs per second ping Services

Dashboards:

Details

SubjectRepoBranchLines +/-
Enable post edit constraint jobs in all editsoperations/mediawiki-configmaster+1 -1
Increase post edit constraint jobs to 85% of editsoperations/mediawiki-configmaster+1 -1
wikidata: post edit constraint jobs on 70% of editsoperations/mediawiki-configmaster+1 -1
wikidata: post edit constraint jobs on 60% of editsoperations/mediawiki-configmaster+1 -1
wikidata: post edit constraint jobs on 50% of editsoperations/mediawiki-configmaster+1 -1
wikidata: post edit constraint jobs on 40% of editsoperations/mediawiki-configmaster+1 -1
wikidata: post edit constraint jobs on 100% of editsoperations/mediawiki-configmaster+1 -1
wikidata: post edit constraint jobs on 50% of editsoperations/mediawiki-configmaster+1 -1
wgWBQualityConstraintsCacheCheckConstraintsResults true on testwikidataoperations/mediawiki-configmaster+1 -0
Add the constraintsRunCheck job definitionmediawiki/services/change-propagation/jobqueue-deploymaster+2 -0
wikidata: post edit constraint jobs on 25% of editsoperations/mediawiki-configmaster+1 -1
wikidata: post edit constraint jobs on 10% of editsoperations/mediawiki-configmaster+1 -1
wikidata: post edit constraint jobs on 5% of editsoperations/mediawiki-configmaster+1 -1
ConstraintsCheckJobs enabled on testwikidatawiki (1% of edits)operations/mediawiki-configmaster+1 -1
ConstraintsCheckJobs enabled on testwikidatawikioperations/mediawiki-configmaster+1 -0
Fix constraintsRunCheck Job class & testmediawiki/extensions/WikibaseQualityConstraintswmf/1.33.0-wmf.13+11 -1
Fix constraintsRunCheck Job class & testmediawiki/extensions/WikibaseQualityConstraintswmf/1.33.0-wmf.12+11 -1
Fix constraintsRunCheck Job class & testmediawiki/extensions/WikibaseQualityConstraintsmaster+11 -1
wgWBQualityConstraintsEnableConstraintsCheckJobs falseoperations/mediawiki-configmaster+0 -1
wikidata: post edit constraint jobs on 1% of editsoperations/mediawiki-configmaster+1 -0
testwikidata: post edit constraint jobs on 100% of editsoperations/mediawiki-configmaster+1 -1
testwikidata: post edit constraint jobs on 50% of editsoperations/mediawiki-configmaster+5 -0
BETA wikidata: post edit constraint jobs on 100% of editsoperations/mediawiki-configmaster+4 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Addshore moved this task from Active 🚁 to Watching 👀 on the User-Addshore board.Oct 31 2019, 2:44 PM
Addshore mentioned this in T240884: RFC: How to evaluate user-provided regular expressions.Jan 14 2020, 6:25 PM
Addshore added a comment.Jan 29 2020, 8:21 AM

Looking at https://grafana.wikimedia.org/d/000000489/wikidata-query-service?orgId=1&var-cluster_name=wdqs-internal&from=now-90d&to=now im not seeing any throttled or banned requests for the internal cluster in the last 3 months.
Maybe the work on improving the updater etc means we might be able to bump this up further?

This month T240884: RFC: How to evaluate user-provided regular expressions was also discussed and we will try to implement a regex checking service so that we can complete T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions)

Will ping the query service team before we thinking about increasing this at all.

gerritbot added a comment.Feb 12 2020, 8:09 PM

Change 484633 had a related patch set uploaded (by Jforrester; owner: Addshore):
[operations/mediawiki-config@master] wikidata: post edit constraint jobs on 50% of edits

https://gerrit.wikimedia.org/r/484633

gerritbot added a comment.Feb 12 2020, 8:09 PM

Change 484635 had a related patch set uploaded (by Jforrester; owner: Addshore):
[operations/mediawiki-config@master] wikidata: post edit constraint jobs on 100% of edits

https://gerrit.wikimedia.org/r/484635

Addshore changed the task status from Stalled to Open.Feb 17 2020, 8:28 AM
Addshore lowered the priority of this task from Medium to Low.
Addshore moved this task from Blocked / Waiting / External to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Lydia_Pintscher added a comment.Feb 17 2020, 9:57 AM

Why is this priority low? From the product side I'd put this to at least medium due to it being a prerequisite for regular constraints runs and querying.

Addshore raised the priority of this task from Low to Medium.Feb 18 2020, 11:09 AM
Addshore moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Unconnected Stories on the Wikidata-Campsite board.
gerritbot added a comment.Jun 13 2020, 8:09 PM

Change 484633 abandoned by Addshore:
wikidata: post edit constraint jobs on 50% of edits

https://gerrit.wikimedia.org/r/484633

gerritbot added a comment.Jun 13 2020, 8:10 PM

Change 484635 abandoned by Addshore:
wikidata: post edit constraint jobs on 100% of edits

https://gerrit.wikimedia.org/r/484635

noarave subscribed.Jan 19 2021, 3:06 PM

Per Adam the next step could be 40% for Wikidata.org, in case we want to be extra cautious

Addshore updated the task description. (Show Details)Jan 20 2021, 1:24 PM
darthmon_wmde moved this task from Unconnected Stories to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 20 2021, 1:36 PM
darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore moved this task from Hike Leftovers to legacy-backlog on the [DEPRECATED] wdwb-tech board.Jan 22 2021, 10:39 PM
Addshore edited projects, added [DEPRECATED] wdwb-tech (legacy-backlog); removed [DEPRECATED] wdwb-tech.
Addshore moved this task from Incoming to Active on the [DEPRECATED] wdwb-tech (legacy-backlog) board.
Lydia_Pintscher moved this task from Stalled/Waiting to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 27 2021, 3:38 PM
Rosalie_WMDE claimed this task.Feb 1 2021, 9:28 AM
Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Feb 1 2021, 9:52 AM

Change 660774 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[operations/mediawiki-config@master] wikidata: post edit constrain jobs on 50% of edits

https://gerrit.wikimedia.org/r/660774

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 1 2021, 10:01 AM
noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 1 2021, 10:18 AM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 1 2021, 10:24 AM
gerritbot added a comment.Feb 1 2021, 12:14 PM

Change 660774 merged by jenkins-bot:
[operations/mediawiki-config@master] wikidata: post edit constraint jobs on 40% of edits

https://gerrit.wikimedia.org/r/660774

Stashbot added a comment.Feb 1 2021, 12:19 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-01T12:19:03Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:660774|wikidata: post edit constraint jobs on 40% of edits (T204031)]] (duration: 01m 03s)

Addshore updated the task description. (Show Details)Feb 1 2021, 3:04 PM
Lucas_Werkmeister_WMDE subscribed.Feb 2 2021, 4:19 PM

According to JobQueue EventBus, the insertion rate of this job went up a bit yesterday, but it’s not too extreme (cursor is on the approximate timestamp of the latest deployment):

constraints-job-insertion-rate.png (334×910 px, 39 KB)

I haven’t found any errors related to the job (constraintsRunCheck / CheckConstraintsJob) in Logstash, so everything seems to be fine so far.

noarave moved this task from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 3 2021, 9:49 AM
Lucas_Werkmeister_WMDE claimed this task.Feb 9 2021, 1:10 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE added a subscriber: Rosalie_WMDE.
gerritbot added a comment.Feb 9 2021, 1:14 PM

Change 662967 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] wikidata: post edit constraint jobs on 50% of edits

https://gerrit.wikimedia.org/r/662967

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 9 2021, 1:16 PM
gerritbot added a comment.Feb 11 2021, 12:15 PM

Change 662967 merged by jenkins-bot:
[operations/mediawiki-config@master] wikidata: post edit constraint jobs on 50% of edits

https://gerrit.wikimedia.org/r/662967

Stashbot added a comment.Feb 11 2021, 12:18 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-11T12:18:01Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:662967|wikidata: post edit constraint jobs on 50% of edits (T204031)]] (up from 40%) (duration: 01m 08s)

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 11 2021, 1:11 PM
Addshore moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 24 2021, 11:53 AM

Moving this back to TODO as the goal and final checklist item is to get to 100%

Addshore removed Lucas_Werkmeister_WMDE as the assignee of this task.Mar 4 2021, 3:53 PM
Addshore moved this task from legacy-backlog to Active on the [DEPRECATED] wdwb-tech board.Mar 18 2021, 9:32 AM
Addshore edited projects, added [DEPRECATED] wdwb-tech; removed [DEPRECATED] wdwb-tech (legacy-backlog).
gerritbot added a comment.Apr 8 2021, 2:59 PM

Change 677928 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[operations/mediawiki-config@master] wikidata: post edit constraint jobs on 60% of edits

https://gerrit.wikimedia.org/r/677928

Restricted Application added a subscriber: Zabe. · View Herald TranscriptApr 8 2021, 2:59 PM
• Tonina_Zhelyazkova_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 8 2021, 3:01 PM
gerritbot added a comment.Apr 12 2021, 11:11 AM

Change 677928 merged by jenkins-bot:

[operations/mediawiki-config@master] wikidata: post edit constraint jobs on 60% of edits

https://gerrit.wikimedia.org/r/677928

Stashbot added a comment.Apr 12 2021, 11:13 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-12T11:13:42Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:677928|wikidata: post edit constraint jobs on 60% of edits (T204031)]] (duration: 01m 13s)

Silvan_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 12 2021, 11:17 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 12 2021, 11:18 AM
Addshore moved this task from Test (Verification) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 14 2021, 9:26 AM

Looking good, I'll put it in waiting until camp feels ready for it to be back in TODO for the next jump

• Tonina_Zhelyazkova_WMDE moved this task from Stalled/Waiting to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 26 2021, 10:16 AM
• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)Apr 26 2021, 11:50 AM
• Tonina_Zhelyazkova_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 26 2021, 12:06 PM
gerritbot added a comment.Apr 26 2021, 12:06 PM

Change 682608 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[operations/mediawiki-config@master] wikidata: post edit constraint jobs on 70% of edits

https://gerrit.wikimedia.org/r/682608

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 26 2021, 12:11 PM
gerritbot added a comment.May 3 2021, 11:01 AM

Change 682608 merged by jenkins-bot:

[operations/mediawiki-config@master] wikidata: post edit constraint jobs on 70% of edits

https://gerrit.wikimedia.org/r/682608

Stashbot added a comment.May 3 2021, 11:04 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-03T11:04:41Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: f1a5ef0116c77b86b1abfb7bfa7d4ed363c69f61: wikidata: post edit constraint jobs on 70% of edits (T204031) (duration: 00m 57s)

• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)May 3 2021, 11:07 AM
• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 4 2021, 8:40 AM
Michael subscribed.May 31 2021, 11:40 AM
This comment was removed by Michael.
Ladsgroup subscribed.May 31 2021, 3:07 PM
Ladsgroup added a comment.May 31 2021, 3:10 PM

Should we wait until T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions) is done and then move forward with it. It looks sensible to do it this way.

Addshore added a comment.Jun 16 2021, 9:36 AM
In T204031#7124569, @Ladsgroup wrote:

Should we wait until T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions) is done and then move forward with it. It looks sensible to do it this way.

We can do (as it is being tackled right now)

Addshore added a project: wikidata-campsite-a-b-split.Jun 28 2021, 1:14 PM
Addshore moved this task from Backlog to Team A owned & driven on the wikidata-campsite-a-b-split board.Jun 28 2021, 1:18 PM
Addshore mentioned this in T285104: Deploy Shellbox instance (shellbox-constraints) for Wikidata constraint regexes.Jul 1 2021, 10:55 PM
Michael changed the task status from Open to Stalled.Jul 27 2021, 9:11 AM

This is stalled on T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions), which in turn is stalled on T285104: Deploy Shellbox instance (shellbox-constraints) for Wikidata constraint regexes.

Ladsgroup changed the task status from Stalled to Open.Aug 9 2021, 8:23 AM
Ladsgroup claimed this task.
Ladsgroup moved this task from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 9 2021, 8:23 AM
gerritbot added a comment.Aug 9 2021, 8:38 AM

Change 710925 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Increase post edit constraint jobs to 85% of edits

https://gerrit.wikimedia.org/r/710925

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 9 2021, 8:41 AM
gerritbot added a comment.Aug 9 2021, 9:45 AM

Change 710925 merged by jenkins-bot:

[operations/mediawiki-config@master] Increase post edit constraint jobs to 85% of edits

https://gerrit.wikimedia.org/r/710925

Stashbot added a comment.Aug 9 2021, 9:49 AM

Mentioned in SAL (#wikimedia-operations) [2021-08-09T09:49:30Z] <ladsgroup@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:710925|Increase post edit constraint jobs to 85% of edits (T204031)]] (duration: 00m 58s)

gerritbot added a comment.Aug 9 2021, 10:16 AM

Change 710936 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Enable post edit constraint jobs in all edits

https://gerrit.wikimedia.org/r/710936

gerritbot added a comment.Aug 9 2021, 10:25 AM

Change 710936 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable post edit constraint jobs in all edits

https://gerrit.wikimedia.org/r/710936

Stashbot added a comment.Aug 9 2021, 10:27 AM

Mentioned in SAL (#wikimedia-operations) [2021-08-09T10:27:05Z] <ladsgroup@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:710936|Enable post edit constraint jobs in all edits (T204031)]] (duration: 00m 58s)

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 9 2021, 10:28 AM
Addshore closed this task as Resolved.Aug 11 2021, 12:46 PM
Ladsgroup added a comment.Aug 11 2021, 12:47 PM

Macro itshappening:

Daniel_Mietchen awarded a token.Aug 17 2021, 3:10 AM
VladimirAlexiev mentioned this in T201150: Regularly run constraint checks for all items.Sep 9 2021, 10:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
INTERN 2
Note 1
Project 5
todo 2