When viewing the details of an old AbuseLog entries, if you look at the content of wgAbuseFilterVariables in the JS console you'll notice that variables still have the old names: article_text etc. For new entries (after the introduction of new variables), new names are used. I guess this is because wgAbuseFilterVariables is generated when recording the hit, so it's obvious that it has old names. For this reason, I wouldn't advice changing them in the DB. However, we should probably map them to the new names on the fly before adding them to the page.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Add a maintenance script to clean afl_var_dump | mediawiki/extensions/AbuseFilter | master | +1 K -1 |
Related Objects
- Mentioned Here
- T204236: Old variables are computed wrongly for old entries
Event Timeline
If we decide to change old dumps as part of T204236, this would be automatically fixed.
Change 482499 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Add a maintenance script to clean afl_var_dump
Change 482499 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] [WIP] Add a maintenance script to clean afl_var_dump
Change 482499 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add a maintenance script to clean afl_var_dump
@Daimona: Related patch in Gerrit has been merged. Thus I'm closing this task as resolved. If there is more work, please reopen and elaborate. Thanks.
(Confirming that this was fixed by running the maintenance script, thanks for closing!)