Now that the Trusty grid is gone from Toolforge, there is a lot of puppet code that can be dropped. Specially in the */toollabs/* namespace.
Also, this code is, in general, not following the roles/profile pattern. So a double win.
However, care should be taken to identify missing bits in the new Toolforge code namespace, so we can't simply drop the code using find.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T208843 WMCS - Remove unused legacy code | |||
| Resolved | aborrero | T219362 Toolforge: cleanup unused/old puppet code |
Change 500388 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] toolforge: Remove support for trusty
Change 500388 merged by Muehlenhoff:
[operations/puppet@production] toolforge: Remove support for trusty
Change 502444 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] toollabs: Remove support for trusty/Ubuntu
Change 502444 merged by Muehlenhoff:
[operations/puppet@production] toollabs: Remove support for trusty/Ubuntu
Change 503035 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] Toolforge: cleanup unused puppet code
Change 503040 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] sonofgridengine: don't use old gridengine code
Change 503040 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] sonofgridengine: don't use old gridengine code
Change 503045 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] sonofgridengine: don't use old gridengine code
Change 503045 merged by Bstorm:
[operations/puppet@production] sonofgridengine: don't use old gridengine code
Change 503070 had a related patch set uploaded (by Bstorm; owner: Bstorm):
[operations/puppet@production] sonofgridengine: cleaning up old intermodule dep
Change 503070 merged by Bstorm:
[operations/puppet@production] sonofgridengine: cleaning up old intermodule dep
Change 503035 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] Toolforge: cleanup unused puppet code
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T10:06:19Z] <arturo> T219362 drop the tools-exec-1 puppet prefix
Change 508529 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] toollabs: drop old compute puppet code
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T10:14:48Z] <arturo> T219362 drop the tools-webgrid-generic puppet prefix
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T10:16:36Z] <arturo> T219362 drop the tools-webgrid-lighttpd puppet prefix
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T10:19:13Z] <arturo> T219362 drop the toolsbeta-webgrid-lighttpd puppet prefix
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T10:20:52Z] <arturo> T219362 drop the toolsbeta-webgrid-generic puppet prefix
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T10:22:25Z] <arturo> T219362 drop the toolsbeta-exec puppet prefix
Change 508529 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] toollabs: drop old node puppet code
Change 508535 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] toolforge: refactor static role puppet code
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T11:01:17Z] <arturo> T219362 disable puppet in tools-static servers for puppet code cleanup
Change 508535 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] toolforge: refactor static role puppet code
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T11:10:22Z] <arturo> T219362 enable puppet in tools-static servers and use new puppet role
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T11:12:10Z] <arturo> T219362 drop the tools-services puppet prefix (we are actually using tools-sgeservices)
Change 508542 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] toolforge: refactor redis role from toollabs
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T11:33:24Z] <arturo> T219362 disable puppet in tools-reds servers for puppet code cleanup
Change 508542 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] toolforge: refactor redis role from toollabs
Mentioned in SAL (#wikimedia-cloud) [2019-05-07T11:46:39Z] <arturo> T219362 enable puppet in tools-redis servers and use the new puppet role
Change 508560 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] toolforge: refactor proxy role from toollabs
Most of the unused toolforge code has been cleaned up already. We still have plenty of code in the toollabs namespace, but that code is in use, mostly by k8s and other pieces that weren't upgraded as part of the GE->SGE migration.
I don't think we should mix cleanup tasks with other involving pure upgrades (and the k8s is a pure upgrade project), so I'll close this task now.
I'll merge https://gerrit.wikimedia.org/r/c/operations/puppet/+/508560 soon.
Change 508560 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] toolforge: introduce new proxy role