Regression: MobileFrontend overrides non-existent user page handling in desktop view
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bugreporter
	Mar 20 2020, 2:06 AM

Description

See https://archive.is/Ywlwp

Replication steps

https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson

Developer notes

This should only apply to mobile page views. Likely fall out from T245160

QA steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson and confirm you see the text "Wikipedia does not have a user page with this exact name.
Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Mr_Selenium and confirm the text says "Create a page called User:Mr Selenium" ie. the content is difference
Create a new user and visit your own user page. On mobile it should say "create your own". on desktop it should say ""Wikipedia does not have a user page with this exact name. "

QA Results - Beta

AC	Status	Details
1	✅	T248141#6045522
2	✅	T248141#6045522
3	✅	T248141#6045522

QA Results - Prod

AC	Status	Details
1	✅	T248141#6045530
2	✅	T248141#6045530
3	✅	T248141#6045530

Details

	Subject	Repo	Branch	Lines +/-
	MobileFormatter should run with content provider	mediawiki/extensions/MobileFrontend	master	+5 -1
	Only replace the user page default on mobile	mediawiki/extensions/MobileFrontend	master	+8 -8

Customize query in gerrit

Related Objects

Mentioned In: T248347: Change blank user page to mirror mobile experience (Allow customisations of Article::getSubstituteContent for different namespaces)
Mentioned Here: T248347: Change blank user page to mirror mobile experience (Allow customisations of Article::getSubstituteContent for different namespaces)
T245160: [Bug] Many MobileFormatter lead paragraph transform alerts starting on Feb 11, 2020

Event Timeline

Bugreporter created this task.Mar 20 2020, 2:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2020, 2:06 AM

(broken styles aside tbh it looks better than the desktop default - but this was not intended behaviour from the patch)

Jdlrobson renamed this task from Desktop: MobileFrontend overrided non-existent user page in desktop view to Regression: MobileFrontend overrides non-existent user page handling in desktop view.Mar 20 2020, 4:35 PM

ovasileva triaged this task as High priority.Mar 20 2020, 5:02 PM

This might make sense to make a core feature at some point (or its own tiny extension, bundled with core).

If we do, we'll need to resolve the tech debt around the handling of placeholders for pages that do not yet exist. The different handlers that exist for this in core are currently being bypassed, which likely causes some long-tail extension or gadget compat issues already.

For example, we already have different defaults for most wiki pages vs file pages, and a special header for talk pages. And a variant for when there is no permission to create it.

noarticletext
noarticletext-nopermission
talkpageheader
filepage-nofile-link

And there's more on the extension hooks side as well, such as the hooks used by ArticlePlaceholder and GlobalUserPage, which also handle pages that don't "exist".

Having first-class support for user pages here would certainly make sense. Figuring out where it properly fits in between all these will be a bit more difficult though, so probably best for a later task :)

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Mar 23 2020, 6:03 PM

Jdlrobson claimed this task.Mar 23 2020, 6:09 PM

Jdlrobson mentioned this in T248347: Change blank user page to mirror mobile experience (Allow customisations of Article::getSubstituteContent for different namespaces).Mar 23 2020, 7:36 PM

Change 582892 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Only replace the user page default on mobile

https://gerrit.wikimedia.org/r/582892

gerritbot added a project: Patch-For-Review.Mar 23 2020, 7:37 PM

AntiCompositeNumber awarded a token.Mar 28 2020, 1:23 AM

I use a custom search engine in Firefox to search on the English Wikipedia. When I search for a page that doesn't exit, I am not taken directly to Special:Search. Instead, I see the noarticletext page. If I want to continue searching, I can then click the "Search for "Foo" in existing pages." link.

With this regression, that link doesn't exist. Instead of finding what I'm looking for, I hit a dead end. This happens regularly. I'd quite appreciate the patch above being merged and deployed post-haste.

Jdlrobson merged a task: T248763: mobile-frontend-user-page-no-page-yet interface message shown on desktop.Mar 28 2020, 11:09 PM

Jdlrobson added subscribers: MusikAnimal, Jdrewniak.

Bugreporter merged a task: T248786: Code of MobileFrontend is shown on non-mobile page.Mar 29 2020, 1:57 PM

Bugreporter added subscribers: Kizule, • Petar.petkovic, Aca.

In T248141#6006726, @AntiCompositeNumber wrote:

I use a custom search engine in Firefox to search on the English Wikipedia. When I search for a page that doesn't exit, I am not taken directly to Special:Search. Instead, I see the noarticletext page. If I want to continue searching, I can then click the "Search for "Foo" in existing pages." link.

With this regression, that link doesn't exist. Instead of finding what I'm looking for, I hit a dead end. This happens regularly. I'd quite appreciate the patch above being merged and deployed post-haste.

Are you searching for user pages? I'm seeing the link fine on other namespaces https://en.wikipedia.beta.wmflabs.org/wiki/Foooo (just wanting to clarify this bug is not impacting other places)

Correct. I type !w User:FooBarBaz, which takes me to https://en.wikipedia.org/wiki/User:FooBarBaz, which is a dead end. Other namespaces work as expected (they show a page with a search link). If the user does not exist, like !w User:FooBarBazBin, I also get the expected page.

MBinder_WMF edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q4); removed Web-Team-Backlog (Kanbanana-2019-20-Q3).Mar 31 2020, 10:11 PM

MBinder_WMF moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Mar 31 2020, 10:12 PM

Change 582892 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Only replace the user page default on mobile

https://gerrit.wikimedia.org/r/582892

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 1 2020, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2020, 12:10 AM

Thanks for reviewing @pmiazga . This can now be QAed.

Quick QA: back to normal on beta cluster. Moving to needs QA in production (@Edtadros - this is on next week's train so should be ready April 8)
https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson

Screen Shot 2020-04-01 at 12.25.28 PM.png (1×2 px, 573 KB)

Change 585537 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] MobileFormatter should run with content provider

https://gerrit.wikimedia.org/r/585537

gerritbot added a project: Patch-For-Review.Apr 2 2020, 4:31 PM

@Jdlrobson @ovasileva -- thanks for fixing this. One day, the Growth team wants to work on figuring out how to prompt newcomers to create good userpages, and this bug might provide us some interesting accidental data to analyze. It might be interesting to see whether userpage creations went up or were higher quality during this time period. We don't want to do this analysis right now, but for when we get to it in the future:

Can you tell the exact timestamps of when the bug started and ended?
Did it affect all wikis? Just Wikipedias?

FYI @Trizek-WMF @RHo @nettrom_WMF

Hey there is T248347 to capture that! Have added you as subscriber.

@Jdlrobson @pmiazga When will this be deployed? The current Tech News says “it has been fixed”. This newsletter usually goes out on Mondays in the European evening, so if the patch is deployed before folks read the newsletter, it should happen during the European Mid-day SWAT or at latest during the (American) Morning SWAT. If this isn’t going to happen, I think the newsletter should use future tense.

In T248141#6029459, @Tacsipacsi wrote:

@Jdlrobson @pmiazga When will this be deployed? The current Tech News says “it has been fixed”. This newsletter usually goes out on Mondays in the European evening, so if the patch is deployed before folks read the newsletter, it should happen during the European Mid-day SWAT or at latest during the (American) Morning SWAT. If this isn’t going to happen, I think the newsletter should use future tense.

@Tacsipacsi - the fix is on this week's deployment train, meaning it will start getting deployed tomorrow (April 7) and finish on Thursday (April 9). @Johan - I'll make a correction for Tech News

Nirmos subscribed.Apr 7 2020, 4:12 PM

@Jdlrobson / @ovasileva I'm not clear on what the acceptance criteria are.

Jdlrobson removed a project: Patch-For-Review.Apr 7 2020, 6:19 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs QA in Prod to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.

Krinkle unsubscribed.Apr 7 2020, 6:50 PM

ovasileva moved this task from Needs QA to Needs QA in Prod on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 9 2020, 5:47 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

✅ AC1: Visit https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson and confirm you see the text "Wikipedia does not have a user page with this exact name.

en.wikipedia.beta.wmflabs.org_w_index.php_title=User_Jdlrobson&mobileaction=toggle_view_desktop(iPad).png (2×1 px, 435 KB)

✅ AC2: Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Mr_Selenium and confirm the text says "Create a page called User:Mr Selenium" ie. the content is difference

en.m.wikipedia.beta.wmflabs.org_wiki_User_Mr_Selenium(iPhone X).png (2×1 px, 217 KB)

✅ AC3: Create a new user and visit your own user page. On mobile it should say "create your own". on desktop it should say ""Wikipedia does not have a user page with this exact name. "

en.wikipedia.beta.wmflabs.org_w_index.php_title=User_Edtadros-beta2&mobileaction=toggle_view_desktop(iPhone X).png (2×1 px, 444 KB)

en.m.wikipedia.beta.wmflabs.org_wiki_User_Edtadros-beta2(iPhone X).png (2×1 px, 217 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

✅ AC1: Visit https://en.wikipedia.org/wiki/User:Supername and confirm you see the text "Wikipedia does not have a user page with this exact name.

en.wikipedia.org_wiki_User_Supername(iPad).png (2×1 px, 438 KB)

✅ AC2: Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Mr_Selenium and confirm the text says "Create a page called User:Mr Selenium" ie. the content is difference

en.m.wikipedia.org_w_index.php_title=User_Supername&mobileaction=toggle_view_mobile(iPhone X).png (2×1 px, 194 KB)

✅ AC3: Create a new user and visit your own user page. On mobile it should say "create your own". on desktop it should say ""Wikipedia does not have a user page with this exact name. "

en.m.wikipedia.org_wiki_User_EdTestCommons01(iPhone X).png (2×1 px, 196 KB)

en.wikipedia.org_w_index.php_title=User_EdTestCommons01&mobileaction=toggle_view_desktop(iPad).png (2×1 px, 459 KB)

Edtadros added a project: Product-QA (RW-Test-Cases).Apr 10 2020, 5:59 AM

Edtadros updated the task description. (Show Details)

ovasileva closed this task as Resolved.Apr 10 2020, 9:31 AM

Change 585537 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] MobileFormatter should run with content provider

https://gerrit.wikimedia.org/r/585537

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.28; 2020-04-14); removed MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 14 2020, 12:00 AM

	F31748174: en.m.wikipedia.org_wiki_User_EdTestCommons01(iPhone X).png
	Apr 10 2020, 5:57 AM

	F31748177: en.wikipedia.org_wiki_User_Supername(iPad).png
	Apr 10 2020, 5:57 AM

	F31748175: en.m.wikipedia.org_w_index.php_title=User_Supername&mobileaction=toggle_view_mobile(iPhone X).png
	Apr 10 2020, 5:57 AM

	F31748182: en.wikipedia.org_w_index.php_title=User_EdTestCommons01&mobileaction=toggle_view_desktop(iPad).png
	Apr 10 2020, 5:57 AM

	F31748143: en.wikipedia.beta.wmflabs.org_w_index.php_title=User_Edtadros-beta2&mobileaction=toggle_view_desktop(iPhone X).png
	Apr 10 2020, 5:41 AM

	F31748137: en.wikipedia.beta.wmflabs.org_w_index.php_title=User_Jdlrobson&mobileaction=toggle_view_desktop(iPad).png
	Apr 10 2020, 5:41 AM

	F31748142: en.m.wikipedia.beta.wmflabs.org_wiki_User_Edtadros-beta2(iPhone X).png
	Apr 10 2020, 5:41 AM

	F31748139: en.m.wikipedia.beta.wmflabs.org_wiki_User_Mr_Selenium(iPhone X).png
	Apr 10 2020, 5:41 AM

Regression: MobileFrontend overrides non-existent user page handling in desktop viewClosed, ResolvedPublicActions

Description

Replication steps

Developer notes

QA steps

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA steps

Test Result - Prod

QA steps

Regression: MobileFrontend overrides non-existent user page handling in desktop view
Closed, ResolvedPublic
Actions