Page MenuHomePhabricator

Watchlist Expiry: ClearUserWatchlistJob doesn't delete from watchlist_expiry
Closed, ResolvedPublic

Description

As a Watchlist Expiry user, I want the ClearUserWatchlistJob job should be updated when applicable, so that the watchlist_expiry table only holds information on pages currently being watched.

Acceptance Criteria:

  • The ClearUserWatchlistJob job should be updated to also delete from the watchlist_expiry table if $wgWatchlistExpiry is enabled.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 587614 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Delete watchlist_expiry rows when clearing watchlist with job

https://gerrit.wikimedia.org/r/587614

ifried renamed this task from ClearUserWatchlistJob doesn't delete from watchlist_expiry to Watchlist Expiry: ClearUserWatchlistJob doesn't delete from watchlist_expiry.Apr 9 2020, 4:44 PM

Change 587614 merged by jenkins-bot:
[mediawiki/core@master] Delete watchlist_expiry rows when clearing watchlist with job

https://gerrit.wikimedia.org/r/587614

This is ready for QA. The ClearUserWatchlistJob is used when a user has more than $wgUpdateRowsPerQuery items in their watchlist (default 100).

dom_walden subscribed.

On betawiki, testing clearing my watchlist via:

  • Special:EditWatchlist/clear
  • Special:EditWatchlist/raw (by deleting all the rows)

for a user with over 100 watched items (for a mix of finite and infinite watched items).

Do you sometimes have to wait a while for the ClearUserWatchlistJob to complete, but eventually all the appropriate rows are removed from the watchlist and watchlist_expiry database tables.

ifried moved this task from Product sign-off to Done on the Community-Tech (Kanban-2019-20-Q4) board.
ifried subscribed.

I tested with Special:EditWatchlist/clear & Special:EditWatchlist/raw (by deleting all the rows). I'm marking this work as Done.

  NODES
COMMUNITY 9
Note 3
Project 5