extension.json did not pass validation: The property HookHandlers is not defined and the definition does not allow additional properties
Closed, ResolvedPublic
Actions

Description

In I0c92d40744, I tried to use the new hook registration system from T240307: Hook container with strong types and DI. It seems to work at runtime, but CI complains (console):

13:25:19 There was 1 failure:
13:25:19 
13:25:19 1) ExtensionJsonValidationTest::testPassesValidation with data set #48 ('/workspace/src/extensions/Wik...p.json')
13:25:19 Failed asserting that '/workspace/src/extensions/Wikibase/client/../extension-client-wip.json did not pass validation.\n
13:25:19 [] The property HookHandlers is not defined and the definition does not allow additional properties\n
13:25:19 ' is false.
13:25:19 
13:25:19 /workspace/src/tests/phpunit/structure/ExtensionJsonValidationTest.php:64
13:25:19 /workspace/src/maintenance/doMaintenance.php:105

Are we not supposed to use HookHandlers yet? Is this too bleeding-edge? :D

Related Objects
Search...

Status	Assigned	Task
Resolved	• tstarling	T252798 How should hook implementations access the current request context?
Resolved	• tstarling	T254271 Should HookRunner be in the service container?
Resolved	• tstarling	T240307 Hook container with strong types and DI
Resolved	• tstarling	T252686 extension.json did not pass validation: The property HookHandlers is not defined and the definition does not allow additional properties

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 13 2020, 4:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2020, 4:15 PM

• Pablo-WMDE subscribed.May 13 2020, 6:03 PM

T252060: Documentation updates for new hooks system ff. also talk about the extension.json - something tells me this (new schema version popping up) will not happen in time to unblock our bridge story (T247250), though.

@nnikkhoui and @tstarling can you comment?

Unsure if this was intentionally omitted to prevent people from using it until the new Hooks system is fully released, but I think we need to just add HookHandlers to extension.schema.v2.json.

Actually! Just remembered @tstarling has this change in patch already out (but not yet merged).

In T252686#6135017, @nnikkhoui wrote:

Unsure if this was intentionally omitted to prevent people from using it until the new Hooks system is fully released, but I think we need to just add HookHandlers to extension.schema.v2.json.

In T252686#6135019, @nnikkhoui wrote:

Actually! Just remembered @tstarling has this change in patch already out (but not yet merged).

In T252686#6135017, @nnikkhoui wrote:

Unsure if this was intentionally omitted to prevent people from using it until the new Hooks system is fully released, but I think we need to just add HookHandlers to extension.schema.v2.json.

https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593982/ for reference

CCicalese_WMF removed a project: Platform Engineering.May 13 2020, 9:47 PM

Michael subscribed.May 14 2020, 10:20 AM

CCicalese_WMF moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.May 19 2020, 1:00 PM

I started another attempt to use the new hook container system in Wikibase at I3df8a3a208, and CI is green, so this seems to be working now. Assigning tstarling since he fixed it in I1a8657ff9f.

extension.json did not pass validation: The property HookHandlers is not defined and the definition does not allow additional propertiesClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

extension.json did not pass validation: The property HookHandlers is not defined and the definition does not allow additional properties
Closed, ResolvedPublic
Actions

Related Objects
Search...