⚓ T269235 [X8ehRwpAICgAALHNCUsAAACI] /wiki/clamor ErrorException from line 157 of /srv/mediawiki/php-1.36.0-wmf.20/extensions/CategoryTree/includes/CategoryTreeHooks.php: ParserOutput::mCategoryTreeTag dynamic property write access deprecated [Called from CategoryTreeHooks::parserHook]

Subject	Repo	Branch	Lines +/-
Remove fallback for ParserOutput dynamic property	mediawiki/extensions/CategoryTree	master	+0 -6
Use ParserOutput::extensionData instead of dynamic properties.	mediawiki/extensions/CategoryTree	wmf/1.36.0-wmf.20	+9 -2
Use ParserOutput::extensionData instead of dynamic properties.	mediawiki/extensions/CategoryTree	master	+9 -2

Status	Subtype	Assigned	Task
Resolved		• Pchelolo	T250500 ParserCache / RESTBase / Parsoid integration
Open		None	T263851 Disallow dynamic property access on ParserOutput
Resolved	PRODUCTION ERROR	• Pchelolo	T269235 [X8ehRwpAICgAALHNCUsAAACI] /wiki/clamor ErrorException from line 157 of /srv/mediawiki/php-1.36.0-wmf.20/extensions/CategoryTree/includes/CategoryTreeHooks.php: ParserOutput::mCategoryTreeTag dynamic property write access deprecated [Called from CategoryTreeHooks::parserHook]

hashar created this task.Dec 2 2020, 2:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2020, 2:27 PM

Comes from b1a30eb0c40253737b631521b44232f91d158608 / T263851

hashar mentioned this in T263851: Disallow dynamic property access on ParserOutput.Dec 2 2020, 2:28 PM

hashar added projects: MediaWiki-Parser, Platform Engineering.Dec 2 2020, 2:32 PM

hashar updated the task description. (Show Details)Dec 2 2020, 2:35 PM

hashar added a parent task: T263851: Disallow dynamic property access on ParserOutput.

This is coming from wfDeprecatedMsg( "ParserOutput::{$name} dynamic property write access deprecated", '1.36' ); - thus just a deprecation. The log message looks weirdly different from the deprecation message though.

• Pchelolo claimed this task.Dec 2 2020, 2:40 PM

• Pchelolo edited projects, added Platform Team Workboards (Green); removed Platform Engineering.

Change 644842 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/CategoryTree@master] Use ParserOutput::extensionData instead of dynamic properties.

https://gerrit.wikimedia.org/r/644842

gerritbot added a project: Patch-For-Review.Dec 2 2020, 2:50 PM

Change 644849 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/CategoryTree@master] Remove fallback for ParserOutput dynamic property

https://gerrit.wikimedia.org/r/644849

Reedy added a project: MediaWiki-extensions-CategoryTree.Dec 2 2020, 3:23 PM

Change 644842 merged by jenkins-bot:
[mediawiki/extensions/CategoryTree@master] Use ParserOutput::extensionData instead of dynamic properties.

https://gerrit.wikimedia.org/r/644842

Change 644815 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/CategoryTree@wmf/1.36.0-wmf.20] Use ParserOutput::extensionData instead of dynamic properties.

https://gerrit.wikimedia.org/r/644815

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 2 2020, 6:00 PM

• Pchelolo moved this task from Backlog to Ready to Deploy on the Platform Team Workboards (Green) board.Dec 2 2020, 6:00 PM

• Pchelolo mentioned this in T263186: 1.36.0-wmf.20 deployment blockers.

thcipriani moved this task from Untriaged to Nov 2020 on the Wikimedia-production-error board.Dec 2 2020, 7:49 PM

Change 644815 merged by jenkins-bot:
[mediawiki/extensions/CategoryTree@wmf/1.36.0-wmf.20] Use ParserOutput::extensionData instead of dynamic properties.

https://gerrit.wikimedia.org/r/644815

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.20; 2020-12-01); removed MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 2 2020, 10:00 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-02T22:43:05Z] <twentyafterfour@deploy1001> Synchronized php-1.36.0-wmf.20/extensions/CategoryTree/: Deploying backport f6c2d74259b9 to wmf.20, bug: T269235 refs T263186 (duration: 01m 07s)